From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1C3C43143 for ; Tue, 2 Oct 2018 13:17:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC0152083F for ; Tue, 2 Oct 2018 13:17:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC0152083F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbeJBUAX (ORCPT ); Tue, 2 Oct 2018 16:00:23 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37138 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbeJBUAX (ORCPT ); Tue, 2 Oct 2018 16:00:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AA717A9; Tue, 2 Oct 2018 06:17:05 -0700 (PDT) Received: from queper01-lin (queper01-lin.emea.arm.com [10.4.13.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E0CC3F5B3; Tue, 2 Oct 2018 06:17:01 -0700 (PDT) Date: Tue, 2 Oct 2018 14:16:59 +0100 From: Quentin Perret To: Peter Zijlstra Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, mingo@redhat.com, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, chris.redpath@arm.com, patrick.bellasi@arm.com, valentin.schneider@arm.com, vincent.guittot@linaro.org, thara.gopinath@linaro.org, viresh.kumar@linaro.org, tkjos@google.com, joel@joelfernandes.org, smuckle@google.com, adharmap@codeaurora.org, skannan@codeaurora.org, pkondeti@codeaurora.org, juri.lelli@redhat.com, edubezval@gmail.com, srinivas.pandruvada@linux.intel.com, currojerez@riseup.net, javi.merino@kernel.org Subject: Re: [PATCH v7 06/14] sched/topology: Reference the Energy Model of CPUs when available Message-ID: <20181002131657.7lysubukna4tkjly@queper01-lin> References: <20180912091309.7551-1-quentin.perret@arm.com> <20180912091309.7551-7-quentin.perret@arm.com> <20181002123617.GB3439@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181002123617.GB3439@hirez.programming.kicks-ass.net> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 02 Oct 2018 at 14:36:17 (+0200), Peter Zijlstra wrote: > On Wed, Sep 12, 2018 at 10:13:01AM +0100, Quentin Perret wrote: > > +struct perf_domain { > > + struct em_perf_domain *obj; > > + struct perf_domain *next; > > + struct rcu_head rcu; > > +}; > > Maybe s/obj/em_pd/ or something like that? @obj is so very opaque. I wanted to avoid calling it just 'pd' since that could be confusing. So anything different than that is fine by me. I don't have a better suggestion than 'em_pd', so I'd say let's stick with that for now. Thanks, Quentin