From: Mike Travis <mike.travis@hpe.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Hedi Berriche <hedi.berriche@hpe.com>,
Russ Anderson <russ.anderson@hpe.com>,
Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Borislav Petkov <bp@alien8.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Peter Zijlstra <peterz@infradead.org>,
Len Brown <len.brown@intel.com>,
Dou Liyang <douly.fnst@cn.fujitsu.com>,
Xiaoming Gao <gxm.linux.kernel@gmail.com>,
Rajvi Jingar <rajvi.jingar@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: [PATCH 2/2] x86/tsc: Fix UV TSC initialization
Date: Tue, 02 Oct 2018 13:01:46 -0500 [thread overview]
Message-ID: <20181002180144.923579706@stormcage.americas.sgi.com> (raw)
In-Reply-To: <20181002180144.636925675@stormcage.americas.sgi.com>
[-- Attachment #1: fix_tsc_early_init --]
[-- Type: text/plain, Size: 1511 bytes --]
Fix regression introduced by
commit cf7a63ef4e02 ("x86/tsc: Calibrate tsc only once")
as it added a call to tsc_early_init() which initializes the TSC ADJUST
values before acpi_boot_table_init(). In the case of UV systems,
that is a necessary step thats calls uv_system_init(). This informs
tsc_sanitize_first_cpu() that we're on a platform with async TSC resets
as documented in
commit 341102c3ef29 ("x86/tsc: Add option that TSC on Socket 0 being non-zero is valid")
Fix by skipping the early tsc initialization on UV systems and let TSC
init tests take place later in tsc_init().
Fixes: cf7a63ef4e02 ("x86/tsc: Calibrate tsc only once")
Signed-off-by: Mike Travis <mike.travis@hpe.com>
Suggested-by: Hedi Berriche <hedi.berriche@hpe.com>
Reviewed-by: Russ Anderson <rja@hpe.com>
Reviewed-by: Dimitri Sivanich <sivanich@hpe.com>
---
arch/x86/kernel/tsc.c | 4 ++++
1 file changed, 4 insertions(+)
--- linux.orig/arch/x86/kernel/tsc.c
+++ linux/arch/x86/kernel/tsc.c
@@ -26,6 +26,7 @@
#include <asm/apic.h>
#include <asm/intel-family.h>
#include <asm/i8259.h>
+#include <asm/uv/uv.h>
unsigned int __read_mostly cpu_khz; /* TSC clocks / usec, not used here */
EXPORT_SYMBOL(cpu_khz);
@@ -1433,6 +1434,9 @@ void __init tsc_early_init(void)
{
if (!boot_cpu_has(X86_FEATURE_TSC))
return;
+ /* Don't change UV TSC multi-chassis synchronization */
+ if (is_early_uv_system())
+ return;
if (!determine_cpu_tsc_frequencies(true))
return;
loops_per_jiffy = get_loops_per_jiffy();
--
next prev parent reply other threads:[~2018-10-02 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 18:01 [PATCH 0/2] Fix TSC ADJUST breakage causing TSC failure Mike Travis
2018-10-02 18:01 ` [PATCH 1/2] x86/platform/uv: Add is_early_uv_system check Mike Travis
2018-10-02 19:33 ` [tip:x86/urgent] x86/platform/uv: Provide is_early_uv_system() tip-bot for Mike Travis
2018-10-02 18:01 ` Mike Travis [this message]
2018-10-02 19:34 ` [tip:x86/urgent] x86/tsc: Fix UV TSC initialization tip-bot for Mike Travis
-- strict thread matches above, loose matches on Subject: below --
2018-10-02 1:22 [PATCH 0/2] Fix community TSC ADJUST breakage causing TSC failure Mike Travis
2018-10-02 1:22 ` [PATCH 2/2] x86/tsc: Fix UV TSC initialization Mike Travis
2018-10-02 6:22 ` Thomas Gleixner
2018-10-02 14:21 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002180144.923579706@stormcage.americas.sgi.com \
--to=mike.travis@hpe.com \
--cc=bp@alien8.de \
--cc=dimitri.sivanich@hpe.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=gxm.linux.kernel@gmail.com \
--cc=hedi.berriche@hpe.com \
--cc=hpa@zytor.com \
--cc=kstewart@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=rajvi.jingar@intel.com \
--cc=russ.anderson@hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®