From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Arnd Bergmann <arnd@arndb.de>,
Linux I2C <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] eeprom: New ee1004 driver for DDR4 memory
Date: Tue, 2 Oct 2018 15:27:27 -0700 [thread overview]
Message-ID: <20181002222727.GB19204@kroah.com> (raw)
In-Reply-To: <20181002114346.4bcf7927@endymion>
On Tue, Oct 02, 2018 at 11:43:46AM +0200, Jean Delvare wrote:
> On Mon, 26 Feb 2018 14:40:42 +0100, Bartosz Golaszewski wrote:
> > 2018-02-26 10:20 GMT+01:00 Jean Delvare <jdelvare@suse.de>:
> > > The EEPROMs which hold the SPD data on DDR4 memory modules are no
> > > longer standard AT24C02-compatible EEPROMs. They are 512-byte EEPROMs
> > > which use only 1 I2C address for data access. You need to switch
> > > between the lower page and the upper page of data by sending commands
> > > on the SMBus.
> > >
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > > ---
> > > drivers/misc/eeprom/Kconfig | 11 +
> > > drivers/misc/eeprom/Makefile | 1
> > > drivers/misc/eeprom/ee1004.c | 281 +++++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 293 insertions(+)
> >
> > is there any reason not to use regmap as is done currently in at24? It
> > would spare you a lot of code.
>
> As it turns out, I don't have the time to look into this. The driver is
> not exactly big, it is functional, and I would hate if someone else
> would duplicate the work just because my driver is not upstream.
>
> So, Greg, can we just get the driver in the kernel tree as is, and if
> anyone really cares about it using regmap, that person will convert the
> driver later?
Fine with me, but someone needs to resend it as it is no longer in my
patch queue at all...
thanks,
greg k-h
next prev parent reply other threads:[~2018-10-02 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 9:20 Jean Delvare
2018-02-26 13:40 ` Bartosz Golaszewski
2018-02-26 14:26 ` Jean Delvare
2018-02-26 14:32 ` Bartosz Golaszewski
2018-10-02 9:43 ` Jean Delvare
2018-10-02 22:27 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-20 9:35 Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002222727.GB19204@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®