From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90CE1C00449 for ; Wed, 3 Oct 2018 10:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51024213A2 for ; Wed, 3 Oct 2018 10:42:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51024213A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726806AbeJCRaL (ORCPT ); Wed, 3 Oct 2018 13:30:11 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:49302 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726544AbeJCRaL (ORCPT ); Wed, 3 Oct 2018 13:30:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E841818A; Wed, 3 Oct 2018 03:42:22 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.emea.arm.com [10.4.12.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7DDF73F5A0; Wed, 3 Oct 2018 03:42:21 -0700 (PDT) Date: Wed, 3 Oct 2018 11:42:18 +0100 From: Catalin Marinas To: Arnd Bergmann Cc: Will Deacon , Mark Rutland , Ard Biesheuvel , Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: arch_timer: avoid unused function warning Message-ID: <20181003104218.GC12998@arrakis.emea.arm.com> References: <20181002211214.2672576-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181002211214.2672576-1-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 02, 2018 at 11:11:44PM +0200, Arnd Bergmann wrote: > arm64_1188873_read_cntvct_el0() is protected by the correct > CONFIG_ARM64_ERRATUM_1188873 #ifdef, but the only reference to it is > also inside of an CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND section, > and causes a warning if that is disabled: > > drivers/clocksource/arm_arch_timer.c:323:20: error: 'arm64_1188873_read_cntvct_el0' defined but not used [-Werror=unused-function] > > Since the erratum requires that we always apply the workaround > in the timer driver, select that symbol as we do for SoC > specific errata. > > Fixes: 95b861a4a6d9 ("arm64: arch_timer: Add workaround for ARM erratum 1188873") > Signed-off-by: Arnd Bergmann Applied. Thanks. -- Catalin