From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF434C00449 for ; Wed, 3 Oct 2018 16:22:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 929522098A for ; Wed, 3 Oct 2018 16:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 929522098A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727269AbeJCXLo (ORCPT ); Wed, 3 Oct 2018 19:11:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:60620 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726811AbeJCXLo (ORCPT ); Wed, 3 Oct 2018 19:11:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E3DE9AA71; Wed, 3 Oct 2018 16:22:37 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id B34581E3613; Wed, 3 Oct 2018 18:22:37 +0200 (CEST) Date: Wed, 3 Oct 2018 18:22:37 +0200 From: Jan Kara To: john.hubbard@gmail.com Cc: Matthew Wilcox , Michal Hocko , Christopher Lameter , Jason Gunthorpe , Dan Williams , Jan Kara , Al Viro , linux-mm@kvack.org, LKML , linux-rdma , linux-fsdevel@vger.kernel.org, John Hubbard Subject: Re: [PATCH 2/4] mm: introduce put_user_page(), placeholder version Message-ID: <20181003162237.GH24030@quack2.suse.cz> References: <20180928053949.5381-1-jhubbard@nvidia.com> <20180928053949.5381-4-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180928053949.5381-4-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 27-09-18 22:39:48, john.hubbard@gmail.com wrote: > From: John Hubbard > > Introduces put_user_page(), which simply calls put_page(). > This provides a way to update all get_user_pages*() callers, > so that they call put_user_page(), instead of put_page(). > > Also adds release_user_pages(), a drop-in replacement for > release_pages(). This is intended to be easily grep-able, > for later performance improvements, since release_user_pages > is not batched like release_pages() is, and is significantly > slower. A small nit but can we maybe call this put_user_pages() for symmetry with put_user_page()? I don't really care too much but it would look natural to me. Honza -- Jan Kara SUSE Labs, CR