From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E989FC64EBC for ; Thu, 4 Oct 2018 17:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9E4B2087D for ; Thu, 4 Oct 2018 17:05:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9E4B2087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727788AbeJDX7n (ORCPT ); Thu, 4 Oct 2018 19:59:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51942 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727586AbeJDX7m (ORCPT ); Thu, 4 Oct 2018 19:59:42 -0400 Received: from localhost (c-67-183-145-105.hsd1.wa.comcast.net [67.183.145.105]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D48E111693739; Thu, 4 Oct 2018 09:58:45 -0700 (PDT) Date: Thu, 04 Oct 2018 09:58:45 -0700 (PDT) Message-Id: <20181004.095845.964782412753569093.davem@davemloft.net> To: natechancellor@gmail.com Cc: Ariel.Elior@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ndesaulniers@google.com, Dept-EngEverestLinuxL2@cavium.com, Tomer.Tayar@cavium.com Subject: Re: [PATCH v2] qed: Avoid implicit enum conversion in qed_ooo_submit_tx_buffers From: David Miller In-Reply-To: <20181004163919.13972-1-natechancellor@gmail.com> References: <20181004000912.22242-1-natechancellor@gmail.com> <20181004163919.13972-1-natechancellor@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Oct 2018 09:58:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor Date: Thu, 4 Oct 2018 09:39:20 -0700 > Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/ethernet/qlogic/qed/qed_ll2.c:799:32: warning: implicit > conversion from enumeration type 'enum core_tx_dest' to different > enumeration type 'enum qed_ll2_tx_dest' [-Wenum-conversion] > tx_pkt.tx_dest = p_ll2_conn->tx_dest; > ~ ~~~~~~~~~~~~^~~~~~~ > 1 warning generated. > > Fix this by using a switch statement to convert between the enumerated > values since they are not 1 to 1, which matches how the rest of the > driver handles this conversion. > > Link: https://github.com/ClangBuiltLinux/linux/issues/125 > Suggested-by: Tomer Tayar > Signed-off-by: Nathan Chancellor > --- > > v1 -> v2: > > * Use an explicit switch statement to convert between the enumerated > types like the rest of the driver, as suggested by Tomer. Applied to net-next.