From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
jacopo@jmondi.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH v8 3/3] [media] imx214: Fix range for V4L2_CID_EXPOSURE
Date: Fri, 5 Oct 2018 14:49:39 +0200 [thread overview]
Message-ID: <20181005124940.15539-3-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <20181005124940.15539-1-ricardo.ribalda@gmail.com>
Going above 3184 changes the frame-rate of the sensor. Without this
patch there is no way to change the exposure without affecting the
frame-rate.
With the proper documentation we should be able the change the
frame-rate at wish, but until that happens we just cap what the sensor
can do.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/media/i2c/imx214.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 46a2fdfbd049..0b99123161b8 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -1027,7 +1027,7 @@ static int imx214_probe(struct i2c_client *client)
*/
imx214->exposure = v4l2_ctrl_new_std(&imx214->ctrls, &imx214_ctrl_ops,
V4L2_CID_EXPOSURE,
- 0, 0xffff, 1, 0x0c70);
+ 0, 3184, 1, 0x0c70);
ret = imx214->ctrls.error;
if (ret) {
--
2.19.0
next prev parent reply other threads:[~2018-10-05 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 12:49 [PATCH v8 1/3] [media] imx214: device tree binding Ricardo Ribalda Delgado
2018-10-05 12:49 ` [PATCH v8 2/3] [media] imx214: Add imx214 camera sensor driver Ricardo Ribalda Delgado
2018-10-05 12:49 ` Ricardo Ribalda Delgado [this message]
2018-10-05 20:32 ` [PATCH v8 1/3] [media] imx214: device tree binding Rob Herring
2018-10-05 21:34 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005124940.15539-3-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome