From: Arnd Bergmann <arnd@arndb.de>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
YueHaibing <yuehaibing@huawei.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] [v2] interconnect: fix build error without DEBUGFS
Date: Fri, 5 Oct 2018 18:14:26 +0200 [thread overview]
Message-ID: <20181005161438.801080-1-arnd@arndb.de> (raw)
The previous fix was incorrect, and now we get a build failure
without CONFIG_DEBUG_FS:
drivers/interconnect/core.c: In function 'icc_init':
drivers/interconnect/core.c:710:32: error: 'icc_summary_fops' undeclared (first use in this function)
Removing the last #ifdef as well makes it all work as intended.
Fixes: 8f023d0cb757 ("interconnect: core: Fix unused variable compiler warning")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I had sent a different fix earlier, but that was done fore the
8f023d0cb757 commit got applied and conflicted with it, so this
new version should go on top.
---
drivers/interconnect/core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index ba48aa83a4ac..aac7bdd6c659 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -52,8 +52,6 @@ struct icc_path {
struct icc_req reqs[];
};
-#ifdef CONFIG_DEBUG_FS
-
static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
{
if (!n)
@@ -106,7 +104,6 @@ static const struct file_operations icc_summary_fops = {
.llseek = seq_lseek,
.release = single_release,
};
-#endif
static struct icc_node *node_find(const int id)
{
--
2.18.0
reply other threads:[~2018-10-05 16:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005161438.801080-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=georgi.djakov@linaro.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®