From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14511C00449 for ; Fri, 5 Oct 2018 16:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D95C12064A for ; Fri, 5 Oct 2018 16:29:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D95C12064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728670AbeJEX3B (ORCPT ); Fri, 5 Oct 2018 19:29:01 -0400 Received: from mail.bootlin.com ([62.4.15.54]:52641 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727941AbeJEX3B (ORCPT ); Fri, 5 Oct 2018 19:29:01 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 3477520802; Fri, 5 Oct 2018 18:29:32 +0200 (CEST) Received: from bbrezillon (unknown [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id BC84F207CC; Fri, 5 Oct 2018 18:29:31 +0200 (CEST) Date: Fri, 5 Oct 2018 18:29:31 +0200 From: Boris Brezillon To: Ricardo Ribalda Delgado Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Zhouyang Jia , linux-mtd@lists.infradead.org, LKML Subject: Re: [PATCH v10 10/10] mtd: maps: gpio-addr-flash: Add support for device-tree devices Message-ID: <20181005182931.172b8f1c@bbrezillon> In-Reply-To: References: <20181004142942.11887-1-ricardo.ribalda@gmail.com> <20181004142942.11887-2-ricardo.ribalda@gmail.com> <20181005002125.12fd229f@bbrezillon> <20181005090811.6b7e9957@bbrezillon> <20181005103730.57d52e3c@bbrezillon> <20181005121235.7e64b64a@bbrezillon> <20181005141057.0f1b0a9b@bbrezillon> <20181005165234.468d2397@bbrezillon> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Oct 2018 17:40:44 +0200 Ricardo Ribalda Delgado wrote: > Hi Boris > On Fri, Oct 5, 2018 at 4:52 PM Boris Brezillon > wrote: > > > > On Fri, 5 Oct 2018 16:06:57 +0200 > > Ricardo Ribalda Delgado wrote: > > > > > Hi again Boris > > > > > > > > > On Fri, Oct 5, 2018 at 2:10 PM Boris Brezillon > > > wrote: > > > > > > > > On Fri, 5 Oct 2018 14:04:52 +0200 > > > > Ricardo Ribalda Delgado wrote: > > > > > > > > > Hi Boris > > > > > On Fri, Oct 5, 2018 at 12:12 PM Boris Brezillon > > > > > wrote: > > > > > > > > > > > > On Fri, 5 Oct 2018 11:54:18 +0200 > > > > > > Ricardo Ribalda Delgado wrote: > > > > > > > > > > > > > Hi Boris > > > > > > > > > > > > > > Just seen that you already did the rebase at > > > > > > > https://github.com/bbrezillon/linux-0day/commits/mtd/physmap-cleanup > > > > > > > > > > > > > > Thanks for that. > > > > > > > > > > > > > > I am about to test it in real hw (unless you want me wait) > > > > > > > > > > > > Sure, go ahead and test it. > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Boris > > > > > I had to change this on your patchset to have it working on hw: > > > > > https://pastebin.com/78A7yhJ9 > > > > > > > > > > If you send the patchset to the mailing list I can review it patch by patch. > > > > > > > > > > Also > > > > > mtd: maps: Prepare merging of physmap and physmap_of > > > > > > > > > > I do not think that can be bisected. (Not sure, I have to test it) > > > > > > > > Okay, I'll have a look. > > > > > > > > > > > > > > I add the diff to the mail, but gmail will probably scramble the > > > > > lines(yes I know I have to use other mail client) > > > > > > > > The diff looks good, I'll fix that an send a push a new version. > > > > > > Also fix on physmap_flash_remove > > > > > > physmap_data->exit(dev); must be called BEFORE > > > map_destroy(info->mtds[i]); > > > > Hm, that's weird. That shouldn't happen. Do you have a non-NULL > > ->exit()? Can you detail why you think ->exit() call is the cause of > > this OOPS? > > > > No idea. It was crashing at: > https://github.com/bbrezillon/linux-0day/blob/mtd/physmap-cleanup/drivers/mtd/chips/cfi_cmdset_0002.c#L2839 > cfi_cmdset_0002.c seesm to play with cfi->chips on its reset callback > > I added some printfs: > > if (!cfi), > if (!chip) > if (!cfi->chips) > > sometimes it crashed on one place, sometimes in another :S. Reading > back our patch it seemed more logical (semantically :P) to > destroy after exit and not the other way around. Actually no, it makes more sense to call ->exit() after destroying the maps, because the platform-specific ->exit() implem might release resources that are used during the destroy_map() operation. Another reason to keep it in this order is that operations in the remove path should be in the reverse order of those done in the probe path, and ->init() is definitely called before map_probe(). > > I made that change and it stopped OOPsing at reboot. Maybe it's just a side effect, especially since I'm pretty sure your physmap_data->exit() is NULL (assuming you do use DT to declare your flash). > > Havent had the time to dig deeper. But if it does not break anything > on your side to invert destroy and exit please do so. It was not > oopsing with my patchset. I'd like to understand what's happening before doing this change. As I said, I fear this reordering just hides something else.