From: Jonas Danielsson <jonas@orbital-systems.com>
To: linux-kernel@vger.kernel.org
Cc: Jonas Danielsson <jonas@orbital-systems.com>,
Sebastian Reichel <sre@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH] power: reset: at91-reset: enable I-cache for at91sam9260_reset
Date: Sun, 7 Oct 2018 14:57:45 +0200 [thread overview]
Message-ID: <20181007125815.8392-1-jonas@threetimestwo.org> (raw)
From: Jonas Danielsson <jonas@orbital-systems.com>
This fixes a bug where our embedded system (AT91SAM9260 based) would
hang at reboot. At the most we managed 16 boot loops without a hang.
With this patch applied the problem has not been observed and the board
has managed above 250 boot loops.
The AT91SAM9260 datasheet tells us that with the instruction cache
disabled all instructions are fetched from SDRAM. And we have an errata
telling us we must power down the SDRAM before issuing cpu reset.
This means we need the instruction cache enabled in at91sam9260_reset()
At the moment it is being disabled in cpu_proc_fin() which is called from
arch/arm/kernel/reboot.c.
Signed-off-by: Jonas Danielsson <jonas@orbital-systems.com>
---
drivers/power/reset/at91-reset.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
index f44a9ffcc2ab..78972bba64df 100644
--- a/drivers/power/reset/at91-reset.c
+++ b/drivers/power/reset/at91-reset.c
@@ -50,14 +50,24 @@ static void __iomem *at91_ramc_base[2], *at91_rstc_base;
static struct clk *sclk;
/*
-* unless the SDRAM is cleanly shutdown before we hit the
+* Errata 43.1.7.1 RSTC: Reset during SDRAM Accesses
+*
+* Unless the SDRAM is cleanly shutdown before we hit the
* reset register it can be left driving the data bus and
* killing the chance of a subsequent boot from NAND
+*
+* Since we are disabling SDRAM need to make sure that the
+* instruction cache is enabled.
*/
static int at91sam9260_restart(struct notifier_block *this, unsigned long mode,
void *cmd)
{
asm volatile(
+ /* Enable I-cache */
+ "mrc p15, 0, r0, c1, c0, 0\n\t"
+ "orr r0, r0, #4096\n\t" /* CR_I (bit 12) */
+ "mcr p15, 0, r0, c1, c0, 0\n\t"
+
/* Align to cache lines */
".balign 32\n\t"
--
2.14.4
next reply other threads:[~2018-10-07 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 12:57 Jonas Danielsson [this message]
2018-10-16 13:30 ` Claudiu.Beznea
2018-10-16 14:15 ` Jonas Danielsson
2018-10-16 14:52 ` Alexander Stein
2018-10-17 12:17 ` Jonas Danielsson
2018-10-17 13:10 ` Claudiu.Beznea
2018-10-19 10:30 ` Jonas Danielsson
2018-10-26 11:05 ` Claudiu.Beznea
2018-10-16 14:03 ` Alexander Stein
2018-10-16 14:19 ` Jonas Danielsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007125815.8392-1-jonas@threetimestwo.org \
--to=jonas@orbital-systems.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®