From: Arnd Bergmann <arnd@arndb.de>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Axel Lin <axel.lin@ingics.com>, Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] regulator: bd718x7: include linux/of.h
Date: Mon, 8 Oct 2018 18:14:32 +0200 [thread overview]
Message-ID: <20181008161444.3871508-1-arnd@arndb.de> (raw)
Without this header, we get a lengthy build error:
drivers/regulator/bd718x7-regulator.c:364:16: error: implicit declaration of function 'of_match_ptr'; did you mean 'hash_ptr'? [-Werror=implicit-function-declaration]
.of_match = of_match_ptr("BUCK1"),
^~~~~~~~~~~~
hash_ptr
drivers/regulator/bd718x7-regulator.c:364:16: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
drivers/regulator/bd718x7-regulator.c:364:16: note: (near initialization for 'bd71847_regulators[0].desc.of_match')
drivers/regulator/bd718x7-regulator.c:364:16: error: initializer element is not constant
drivers/regulator/bd718x7-regulator.c:364:16: note: (near initialization for 'bd71847_regulators[0].desc.of_match')
drivers/regulator/bd718x7-regulator.c:365:23: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
...
Fixes: 2ece646c90c5 ("regulator: bd718xx: rename bd71837 to 718xx")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/regulator/bd718x7-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/bd718x7-regulator.c b/drivers/regulator/bd718x7-regulator.c
index d2522d4e1505..7bf25aafe077 100644
--- a/drivers/regulator/bd718x7-regulator.c
+++ b/drivers/regulator/bd718x7-regulator.c
@@ -9,6 +9,7 @@
#include <linux/kernel.h>
#include <linux/mfd/rohm-bd718x7.h>
#include <linux/module.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/regulator/driver.h>
#include <linux/regulator/machine.h>
--
2.18.0
reply other threads:[~2018-10-08 16:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008161444.3871508-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®