From: Borislav Petkov <bp@alien8.de>
To: Manish Narani <MNARANI@xilinx.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Michal Simek <michals@xilinx.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"sudeep.holla@arm.com" <sudeep.holla@arm.com>,
"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
"leoyang.li@nxp.com" <leoyang.li@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v8 02/10] edac: synopsys: Rename the static functions to a shorter name
Date: Mon, 8 Oct 2018 20:03:38 +0200 [thread overview]
Message-ID: <20181008180338.GB5919@zn.tnic> (raw)
In-Reply-To: <DM6PR02MB52274CC51BE196CF18C97834C1E60@DM6PR02MB5227.namprd02.prod.outlook.com>
On Mon, Oct 08, 2018 at 01:45:28PM +0000, Manish Narani wrote:
> > /**
> > - * synps_edac_get_eccstate - Return the controller ecc enable/disable status
> > - * @base: Pointer to the ddr memory controller base address
> > + * get_ecc_state - Return the controller ECC enable/disable status
>
> Nit: ecc --> ECC correction can be moved to Comments correction patch. Minor. Can keep it here too.
>
All fixed except this one - this one can remain here because the patch
is touching the line anyway.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-10-08 18:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 15:35 [PATCH v8 00/10] EDAC: Enhancements to Synopsys EDAC driver Manish Narani
2018-10-04 15:35 ` [PATCH v8 01/10] edac: synopsys: Update the driver code for better readability Manish Narani
2018-10-04 15:35 ` [PATCH v8 02/10] edac: synopsys: Rename the static functions to a shorter name Manish Narani
2018-10-04 20:35 ` Borislav Petkov
2018-10-08 13:45 ` Manish Narani
2018-10-08 18:03 ` Borislav Petkov [this message]
2018-10-04 15:35 ` [PATCH v8 03/10] edac: synopsys: Modify the comments in the driver Manish Narani
2018-10-04 20:36 ` Borislav Petkov
2018-10-04 15:35 ` [PATCH v8 04/10] edac: synopsys: Make return type void for functions always returning 0 Manish Narani
2018-10-04 15:35 ` [PATCH v8 05/10] edac: synps: Add platform specific structures for ddrc controller Manish Narani
2018-10-05 16:53 ` Borislav Petkov
2018-10-04 15:35 ` [PATCH v8 06/10] dt: bindings: Document ZynqMP DDRC in Synopsys documentation Manish Narani
2018-10-04 15:35 ` [PATCH v8 07/10] edac: synopsys: Add macro defines for ZynqMP DDRC Manish Narani
2018-10-04 15:35 ` [PATCH v8 08/10] edac: synopsys: Add EDAC ECC support " Manish Narani
2018-10-04 15:35 ` [PATCH v8 09/10] arm64: zynqmp: Add DDRC node Manish Narani
2018-10-04 15:35 ` [PATCH v8 10/10] edac: synopsys: Add Error Injection support for ZynqMP DDRC Manish Narani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008180338.GB5919@zn.tnic \
--to=bp@alien8.de \
--cc=MNARANI@xilinx.com \
--cc=amit.kucheria@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michals@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®