From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C8BC64EB8 for ; Tue, 9 Oct 2018 15:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB46721479 for ; Tue, 9 Oct 2018 15:00:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB46721479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbeJIWRv (ORCPT ); Tue, 9 Oct 2018 18:17:51 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:36158 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbeJIWRu (ORCPT ); Tue, 9 Oct 2018 18:17:50 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.09210706|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03306;MF=ren_guo@c-sky.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.D.er2x5_1539097196; Received: from localhost(mailfrom:ren_guo@c-sky.com fp:SMTPD_---.D.er2x5_1539097196) by smtp.aliyun-inc.com(10.147.41.187); Tue, 09 Oct 2018 22:59:56 +0800 Date: Tue, 9 Oct 2018 22:59:56 +0800 From: Guo Ren To: Marc Zyngier Cc: tglx@linutronix.de, jason@lakedaemon.net, robh+dt@kernel.org, mark.rutland@arm.com, daniel.lezcano@linaro.org, anurup.m@huawei.com, Jonathan.Cameron@huawei.com, will.deacon@arm.com, zhangshaokun@hisilicon.com, jhogan@kernel.org, paul.burton@mips.com, peterz@infradead.org, arnd@arndb.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH V10 1/8] irqchip: add C-SKY SMP interrupt controller Message-ID: <20181009145955.GA17681@guoren-Inspiron-7460> References: <404fb433-020e-28f9-2434-a22c6db36a15@arm.com> <20181009022357.GA826@guoren> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Marc, On Tue, Oct 09, 2018 at 09:15:17AM +0100, Marc Zyngier wrote: > >>>+#ifdef CONFIG_SMP > >>>+ set_send_ipi(&csky_mpintc_send_ipi); > >>>+ > >>>+ set_ipi_irq_mapping(&csky_mpintc_ipi_irq_mapping); > >> > >>Since you seem to be inventing a new set_send_ipi callback, why don't you > >>define it as: > >> > >>void set_send_ipi(void (*func)(const struct cpumask *), > >> unsigned int ipi_irq); > >>after having created the mapping for the IPI interrupt? It would avoid this > >>rather pointless mapping callback. > > > >I'll define it to: > > > >void set_send_ipi(void (*func)(const struct cpumask *)); > > > >IPI_IRQ only use software-irq-15 in mpintc driver, so arch needn't care > >about irq-num. > > Except that your SMP code does a request_irq on the result of > create_mapping. Who is going to do that if you don't pass the Linux irq > around? Yes, My SMP code does a request_irq on the result of create_mapping. Here is my smp.c code and it use a result of create_mapping by arch_ipi_irq_mapping() callback in irq-csky-mpintc.c void __init setup_smp_ipi(void) { int rc; ipi_irq = arch_ipi_irq_mapping(); if (ipi_irq == 0) panic("%s IRQ mapping failed\n", __func__); rc = request_percpu_irq(ipi_irq, handle_ipi, "IPI Interrupt", &ipi_dummy_dev); if (rc) panic("%s IRQ request failed\n", __func__); enable_smp_ipi(); } Best Regards Guo Ren