From: Steven Rostedt <rostedt@goodmis.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>,
jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: [PATCH] hwmon: (core) Add trace events to _attr_show/store functions
Date: Tue, 9 Oct 2018 16:42:42 -0400 [thread overview]
Message-ID: <20181009164242.76e397ad@gandalf.local.home> (raw)
In-Reply-To: <20181009203937.GA11222@roeck-us.net>
On Tue, 9 Oct 2018 13:39:37 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> > Personally a checkpatch warning bugs me more than having an extra
> > line :)
> >
> Same here. If we no longer believe in the 80-column limit, we should remove it,
> not use it to hide other problems in the noise.
Yes, please, can we?
I personally hate the 80 character limit rule, because I like
descriptive variables and function names, which itself causes the 80
character limit to be broken. I find line breaks to avoid that limit
just makes the code look worse. Or at least up it to 100 chars.
-- Steve
next prev parent reply other threads:[~2018-10-09 20:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 18:26 Nicolin Chen
2018-10-09 18:57 ` Steven Rostedt
2018-10-09 19:11 ` Nicolin Chen
2018-10-09 19:49 ` Steven Rostedt
2018-10-09 19:57 ` Nicolin Chen
2018-10-09 20:39 ` Guenter Roeck
2018-10-09 20:42 ` Steven Rostedt [this message]
2018-10-09 20:52 ` Guenter Roeck
2018-10-09 20:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009164242.76e397ad@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®