From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D29DAC32788 for ; Thu, 11 Oct 2018 05:29:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 915E92086E for ; Thu, 11 Oct 2018 05:29:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 915E92086E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727794AbeJKMyz (ORCPT ); Thu, 11 Oct 2018 08:54:55 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48970 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbeJKMyy (ORCPT ); Thu, 11 Oct 2018 08:54:54 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1c06::4572]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2480212131DE4; Wed, 10 Oct 2018 22:29:20 -0700 (PDT) Date: Wed, 10 Oct 2018 22:29:19 -0700 (PDT) Message-Id: <20181010.222919.1392544811823497274.davem@davemloft.net> To: natechancellor@gmail.com Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] isdn/hisax: amd7930_fn: Remove unnecessary parentheses From: David Miller In-Reply-To: <20181008225905.24214-1-natechancellor@gmail.com> References: <20181008225905.24214-1-natechancellor@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 10 Oct 2018 22:29:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor Date: Mon, 8 Oct 2018 15:59:05 -0700 > Clang warns when multiple sets of parentheses are used for a single > conditional statement. > > drivers/isdn/hisax/amd7930_fn.c:628:32: warning: equality comparison > with extraneous parentheses [-Wparentheses-equality] > if ((cs->dc.amd7930.ph_state == 8)) { > ~~~~~~~~~~~~~~~~~~~~~~~~^~~~ > drivers/isdn/hisax/amd7930_fn.c:628:32: note: remove extraneous > parentheses around the comparison to silence this warning > if ((cs->dc.amd7930.ph_state == 8)) { > ~ ^ ~ > drivers/isdn/hisax/amd7930_fn.c:628:32: note: use '=' to turn this > equality comparison into an assignment > if ((cs->dc.amd7930.ph_state == 8)) { > ^~ > = > 1 warning generated. > > Signed-off-by: Nathan Chancellor Applied.