Re: [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2972 bytes --]

Hi Juergen,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/x86/core]
[also build test ERROR on v4.19-rc7 next-20181009]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Juergen-Gross/x86-make-rsdp-address-accessible-via-boot-params/20181010-065806
config: i386-allnoconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> arch/x86/kernel/x86_init.c:98:23: error: 'x86_default_get_root_pointer' undeclared here (not in a function); did you mean 'x86_default_pci_init_irq'?
      .get_root_pointer = x86_default_get_root_pointer,
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                          x86_default_pci_init_irq

vim +98 arch/x86/kernel/x86_init.c

    40	
    41		.resources = {
    42			.probe_roms		= probe_roms,
    43			.reserve_resources	= reserve_standard_io_resources,
    44			.memory_setup		= e820__memory_setup_default,
    45		},
    46	
    47		.mpparse = {
    48			.mpc_record		= x86_init_uint_noop,
    49			.setup_ioapic_ids	= x86_init_noop,
    50			.mpc_apic_id		= default_mpc_apic_id,
    51			.smp_read_mpc_oem	= default_smp_read_mpc_oem,
    52			.mpc_oem_bus_info	= default_mpc_oem_bus_info,
    53			.find_smp_config	= default_find_smp_config,
    54			.get_smp_config		= default_get_smp_config,
    55		},
    56	
    57		.irqs = {
    58			.pre_vector_init	= init_ISA_irqs,
    59			.intr_init		= native_init_IRQ,
    60			.trap_init		= x86_init_noop,
    61			.intr_mode_init		= apic_intr_mode_init
    62		},
    63	
    64		.oem = {
    65			.arch_setup		= x86_init_noop,
    66			.banner			= default_banner,
    67		},
    68	
    69		.paging = {
    70			.pagetable_init		= native_pagetable_init,
    71		},
    72	
    73		.timers = {
    74			.setup_percpu_clockev	= setup_boot_APIC_clock,
    75			.timer_init		= hpet_time_init,
    76			.wallclock_init		= x86_init_noop,
    77		},
    78	
    79		.iommu = {
    80			.iommu_init		= iommu_init_noop,
    81		},
    82	
    83		.pci = {
    84			.init			= x86_default_pci_init,
    85			.init_irq		= x86_default_pci_init_irq,
    86			.fixup_irqs		= x86_default_pci_fixup_irqs,
    87		},
    88	
    89		.hyper = {
    90			.init_platform		= x86_init_noop,
    91			.guest_late_init	= x86_init_noop,
    92			.x2apic_available	= bool_x86_init_noop,
    93			.init_mem_mapping	= x86_init_noop,
    94			.init_after_bootmem	= x86_init_noop,
    95		},
    96	
    97		.acpi = {
  > 98			.get_root_pointer	= x86_default_get_root_pointer,
    99			.reduced_hw_early_init	= acpi_generic_reduced_hw_init,
   100		},
   101	};
   102	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6570 bytes --]