Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Thu, Oct 11, 2018 at 08:41:16PM +0200, Linus Walleij wrote:
> On Thu, Oct 11, 2018 at 7:54 PM Mark Brown <broonie@kernel.org> wrote:

> > Other regulators that have GPIO control for their enables do their own
> > requests (as does the core) so don't they all need to set the flag
> > GPIOD_FLAGS_BIT_NONEXCLUSIVE when they request otherwise it'll only work
> > in systems where the regulators after the first that request the GPIO
> > are fixed regulators?

> Yeah ... I guess I assumed that the same enable line is not used
> for a fixed regulator and then some other regulator (which is not
> fixed).

> If this is common practice we need to account for it. Obviously
> I have no idea what is common practice :/

> Do we know some way to identify the affected systems or
> should we just tag on GPIOD_FLAGS_BIT_NONEXCLUSIVE
> on all the stuff we converted to descs to play it safe?
> (I can cook a patch.)

I think we need to set the flag everywhere, previously we'd essentially
been doing it by asking the GPIO framework if we resolved the same
regulator as one we already had.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]