From: Christian Brauner <christian@brauner.io>
To: keescook@chromium.org, linux-kernel@vger.kernel.org
Cc: ebiederm@xmission.com, mcgrof@kernel.org,
akpm@linux-foundation.org, joe.lawrence@redhat.com,
longman@redhat.com, linux@dominikbrodowski.net,
viro@zeniv.linux.org.uk, Christian Brauner <christian@brauner.io>
Subject: [PATCH v1 0/2] sysctl: cap file-max value at ULONG_MAX
Date: Mon, 15 Oct 2018 12:55:42 +0200 [thread overview]
Message-ID: <20181015105544.4395-1-christian@brauner.io> (raw)
Hey,
Here is v1 of this patchset. Changelogs are in the individual commits.
Currently, when writing
echo 18446744073709551616 > /proc/sys/fs/file-max
/proc/sys/fs/file-max will overflow and be set to 0. That quickly
crashes the system. Let's detect the overflow and set to ULONG_MAX in
this case effectively capping the value.
The patch tries to ensure that there is no other user visible change in
behavior for other values. Only when a maximum value is set for a
specific sysctl will it be capped on overflow. The details are outlined
in the commit message of the first commit.
(This patchset is in reference to https://lkml.org/lkml/2018/10/11/585.)
Thanks!
Christian
Christian Brauner (2):
sysctl: cap to ULONG_MAX in proc_get_long()
sysctl: handle overflow for file-max
kernel/sysctl.c | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
--
2.17.1
next reply other threads:[~2018-10-15 10:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 10:55 Christian Brauner [this message]
2018-10-15 10:55 ` [PATCH v1 1/2] sysctl: cap to ULONG_MAX in proc_get_long() Christian Brauner
2018-10-15 16:18 ` Kees Cook
2018-10-15 16:30 ` Christian Brauner
2018-10-15 19:01 ` Christian Brauner
2018-10-15 10:55 ` [PATCH v1 2/2] sysctl: handle overflow for file-max Christian Brauner
2018-10-15 16:11 ` Kees Cook
2018-10-15 16:28 ` Christian Brauner
2018-10-15 21:20 ` Kees Cook
2018-10-16 13:16 ` Christian Brauner
2018-10-16 14:38 ` Christian Brauner
2018-10-16 15:13 ` Waiman Long
2018-10-16 15:21 ` Christian Brauner
2018-10-16 15:25 ` Waiman Long
2018-10-16 15:29 ` Christian Brauner
2018-10-16 15:33 ` Christian Brauner
2018-10-16 15:34 ` Waiman Long
2018-10-16 15:40 ` Christian Brauner
2018-10-16 15:44 ` Waiman Long
2018-10-16 15:47 ` Christian Brauner
2018-10-16 15:53 ` Waiman Long
2018-10-16 15:59 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015105544.4395-1-christian@brauner.io \
--to=christian@brauner.io \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=joe.lawrence@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=longman@redhat.com \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®