mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Sahitya Tummala <stummala@codeaurora.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] f2fs: update REQ_TIME in f2fs_cross_rename()
Date: Mon, 15 Oct 2018 16:03:57 -0700	[thread overview]
Message-ID: <20181015230357.GA1296@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <fa825846-ba41-31d2-c819-476e9245b7a8@huawei.com>

On 10/15, Chao Yu wrote:
> On 2018/10/5 13:17, Sahitya Tummala wrote:
> > Update REQ_TIME in the missing path - f2fs_cross_rename().
> 
> Needs to cover f2fs_rename() as well?

Hi, I've added this in f2fs_rename().

Thanks,

> 
> Thanks,
> 
> > 
> > Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
> > ---
> >  fs/f2fs/namei.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> > index a146327..e37af23 100644
> > --- a/fs/f2fs/namei.c
> > +++ b/fs/f2fs/namei.c
> > @@ -1154,6 +1154,8 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
> >  
> >  	if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
> >  		f2fs_sync_fs(sbi->sb, 1);
> > +
> > +	f2fs_update_time(sbi, REQ_TIME);
> >  	return 0;
> >  out_new_dir:
> >  	if (new_dir_entry) {
> > 

  reply	other threads:[~2018-10-15 23:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  5:17 [PATCH 1/2] f2fs: do not update REQ_TIME in case of error conditions Sahitya Tummala
2018-10-05  5:17 ` [PATCH 2/2] f2fs: update REQ_TIME in f2fs_cross_rename() Sahitya Tummala
2018-10-15 12:00   ` Chao Yu
2018-10-15 23:03     ` Jaegeuk Kim [this message]
2018-10-16  1:34       ` Chao Yu
2018-10-15 11:52 ` [PATCH 1/2] f2fs: do not update REQ_TIME in case of error conditions Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015230357.GA1296@jaegeuk-macbookpro.roam.corp.google.com \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stummala@codeaurora.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®