From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC899C04EB9 for ; Mon, 15 Oct 2018 23:08:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75118208D9 for ; Mon, 15 Oct 2018 23:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YYoOMwFV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75118208D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbeJPGzb (ORCPT ); Tue, 16 Oct 2018 02:55:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:47034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbeJPGzb (ORCPT ); Tue, 16 Oct 2018 02:55:31 -0400 Received: from localhost (unknown [104.132.1.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37E002089D; Mon, 15 Oct 2018 23:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539644888; bh=WfmKgctiGpq0AofLj01CvrrBXv2+fR229Lyrb9kbj/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YYoOMwFV1jN7v9keEYNUDfcO6/oBxJW5yr7QnbDT1BYfovs8AafbugqiwIt+0GhH3 eV+Mr2YqQ7jDQyWNyETq4tfNzBPGa3WkW627PVQgc753exHGJAMK1bZ3GNWqjgQWBE JXPuAlT5om1Gfgl+tU8l5dzrqXcOJFib7/kzSilw= Date: Mon, 15 Oct 2018 16:08:07 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: clear cold data flag if IO is not counted Message-ID: <20181015230807.GC1296@jaegeuk-macbookpro.roam.corp.google.com> References: <20181010212217.52289-1-jaegeuk@kernel.org> <3f08031e-d195-5bc1-67e1-f3b6eab3506b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f08031e-d195-5bc1-67e1-f3b6eab3506b@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15, Chao Yu wrote: > On 2018/10/11 5:22, Jaegeuk Kim wrote: > > If we clear the cold data flag out of the writeback flow, we can miscount > > -1 by end_io. > > I didn't get it, which count do you mean? It's the number of dirty pages. Balancing F2FS Async: - IO (CP: 1, Data: -1, Flush: ( 0 0 1), Discard: ( 0 129304)) cmd: 0 undiscard: 0 > > Thanks, > > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/data.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > > index 29a9d3b8f709..4102799b5558 100644 > > --- a/fs/f2fs/data.c > > +++ b/fs/f2fs/data.c > > @@ -2636,10 +2636,6 @@ static int f2fs_set_data_page_dirty(struct page *page) > > if (!PageUptodate(page)) > > SetPageUptodate(page); > > > > - /* don't remain PG_checked flag which was set during GC */ > > - if (is_cold_data(page)) > > - clear_cold_data(page); > > - > > if (f2fs_is_atomic_file(inode) && !f2fs_is_commit_atomic_write(inode)) { > > if (!IS_ATOMIC_WRITTEN_PAGE(page)) { > > f2fs_register_inmem_page(inode, page); > >