From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wenwen Wang <wang6495@umn.edu>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Kangjie Lu <kjlu@umn.edu>, Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue
Date: Wed, 17 Oct 2018 17:15:33 -0400 [thread overview]
Message-ID: <20181017211532.GB9499@localhost.localdomain> (raw)
In-Reply-To: <1539800299-2787-1-git-send-email-wang6495@umn.edu>
On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote:
> This patch adds a 4-byte reserved field in the structure
> vfio_eeh_pe_op to make sure that the u64 fields in the structure
> vfio_eeh_pe_err are 8-byte aligned.
Won't this break 32-bit kernels? That is the size of the structure
will now be 4 bytes bigger..
>
> Signed-off-by: Wenwen Wang <wang6495@umn.edu>
> ---
> include/uapi/linux/vfio.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> index 1aa7b82..3e71ded 100644
> --- a/include/uapi/linux/vfio.h
> +++ b/include/uapi/linux/vfio.h
> @@ -729,6 +729,7 @@ struct vfio_eeh_pe_op {
> __u32 argsz;
> __u32 flags;
> __u32 op;
> + __u32 __res;
> union {
> struct vfio_eeh_pe_err err;
> };
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-10-17 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 18:18 Wenwen Wang
2018-10-17 21:15 ` Konrad Rzeszutek Wilk [this message]
2018-10-17 22:03 ` Alex Williamson
2018-10-18 17:20 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017211532.GB9499@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=kjlu@umn.edu \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wang6495@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®