From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5E0ECDE43 for ; Thu, 18 Oct 2018 22:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82B9D20866 for ; Thu, 18 Oct 2018 22:41:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82B9D20866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727246AbeJSGon (ORCPT ); Fri, 19 Oct 2018 02:44:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41928 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbeJSGom (ORCPT ); Fri, 19 Oct 2018 02:44:42 -0400 Received: from localhost (c-67-183-62-245.hsd1.wa.comcast.net [67.183.62.245]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F4126140A7518; Thu, 18 Oct 2018 15:41:33 -0700 (PDT) Date: Thu, 18 Oct 2018 15:41:33 -0700 (PDT) Message-Id: <20181018.154133.1613303373005587833.davem@davemloft.net> To: natechancellor@gmail.com Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] atm: zatm: Fix empty body Clang warnings From: David Miller In-Reply-To: <20181017180419.8955-1-natechancellor@gmail.com> References: <20181017180419.8955-1-natechancellor@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Oct 2018 15:41:34 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor Date: Wed, 17 Oct 2018 11:04:19 -0700 > Clang warns: > > drivers/atm/zatm.c:513:7: error: while loop has empty body > [-Werror,-Wempty-body] > zwait; > ^ > drivers/atm/zatm.c:513:7: note: put the semicolon on a separate line to > silence this warning > > Get rid of this warning by using an empty do-while loop. While we're at > it, add parentheses to make it clear that this is a function-like macro. > > Link: https://github.com/ClangBuiltLinux/linux/issues/42 > Suggested-by: Masahiro Yamada > Signed-off-by: Nathan Chancellor Applied.