From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52319C67863 for ; Fri, 19 Oct 2018 00:23:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0ACD92087A for ; Fri, 19 Oct 2018 00:23:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ACD92087A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbeJSI0p (ORCPT ); Fri, 19 Oct 2018 04:26:45 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43454 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbeJSI0p (ORCPT ); Fri, 19 Oct 2018 04:26:45 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7AA36140C2C5B; Thu, 18 Oct 2018 17:23:11 -0700 (PDT) Date: Thu, 18 Oct 2018 17:23:10 -0700 (PDT) Message-Id: <20181018.172310.35380794084221855.davem@davemloft.net> To: natechancellor@gmail.com Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com Subject: Re: [PATCH v2] isdn: hfc_{pci,sx}: Avoid empty body if statements From: David Miller In-Reply-To: <20181019002117.GA10161@flashbox> References: <20181018034935.16819-1-natechancellor@gmail.com> <20181018.154219.1246620018001438422.davem@davemloft.net> <20181019002117.GA10161@flashbox> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Oct 2018 17:23:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor Date: Thu, 18 Oct 2018 17:21:17 -0700 > Thanks for the review, I went ahead and compiled with the following diff > on top of v2 and got no warnings from Clang, GCC, or sparse, does this > seem satisfactory for v3? Well, one thing I notice. > @@ -86,7 +86,7 @@ release_io_hfcpci(struct IsdnCardState *cs) > pci_free_consistent(cs->hw.hfcpci.dev, 0x8000, > cs->hw.hfcpci.fifos, cs->hw.hfcpci.dma); > cs->hw.hfcpci.fifos = NULL; > - iounmap((void *)cs->hw.hfcpci.pci_io); > + iounmap(cs->hw.hfcpci.pci_io); > } Driver uses iounmap(). > @@ -1692,7 +1692,7 @@ setup_hfcpci(struct IsdnCard *card) > printk(KERN_WARNING "HFC-PCI: No IRQ for PCI card found\n"); > return (0); > } > - cs->hw.hfcpci.pci_io = (char *)(unsigned long)dev_hfcpci->resource[1].start; > + cs->hw.hfcpci.pci_io = (void __iomem *)(unsigned long)dev_hfcpci->resource[1].start; > printk(KERN_INFO "HiSax: HFC-PCI card manufacturer: %s card name: %s\n", id_list[i].vendor_name, id_list[i].card_name); But does not use iomap(). You won't need any cast here if it did use iomap() properly. Thanks.