From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9814C46475 for ; Tue, 23 Oct 2018 05:45:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76F0520671 for ; Tue, 23 Oct 2018 05:45:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="KX7imlE7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76F0520671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbeJWOGv (ORCPT ); Tue, 23 Oct 2018 10:06:51 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:36076 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbeJWOGv (ORCPT ); Tue, 23 Oct 2018 10:06:51 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9N5Ywf8055778; Tue, 23 Oct 2018 05:43:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=r3XrQGmVnbIZIHhWq1jCXITer5PMz2fgZ36k9EzQQi4=; b=KX7imlE7tlDeBrjRV+Rsn8FmH1l7WUQQkC21ZD+7SPmhxWl5iPuEfwnmUoZFrnjfyA4e 2CE/QqL3p3iiqItDm2KDckBYgnbgqga8v26djMstKBYYiwPwy+ZwAc8e91TQsxNidpRT h6s65MIVeUPmTpKrwnMEFS/ed3HmPNU1kbSklGS8/veOgl5E11Z7/AMs2rnFKhZ+0NjK 3XH0fXvvLHhdWvj2sVhFDXdxAlC6UMeu9gkH0EO5WWh1H00RUsHKznrbpo8TODBPCPXC S9h58R0Yj5Z6N7PgqdSqBVtF36TJqAYU0q1FHNZGYifKrw8/hsZS6jpAAt9rm6fbT734 Nw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2n7usu2tt9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Oct 2018 05:43:40 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9N5hYvx029144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Oct 2018 05:43:34 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9N5hTNo015515; Tue, 23 Oct 2018 05:43:30 GMT Received: from mwanda (/129.205.6.86) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 22 Oct 2018 22:43:28 -0700 Date: Tue, 23 Oct 2018 08:43:06 +0300 From: Dan Carpenter To: Nick Desaulniers Cc: Miguel Ojeda , Greg KH , LKML , adilger.kernel@dilger.ca, Masahiro Yamada , Michal Marek , rostedt@goodmis.org, mchehab+samsung@kernel.org, olof@lxom.net, Konstantin Ryabitsev , "David S. Miller" , Andrey Ryabinin , Kees Cook , Thomas Gleixner , Ingo Molnar , Paul Lawrence , sandipan@linux.vnet.ibm.com, Andrey Konovalov , David Woodhouse , Will Deacon , Philippe Ombredanne , paul.burton@mips.com, David Rientjes , Willy Tarreau , msebor@gmail.com, sparse@chrisli.org, Jonathan Corbet , "Theodore Ts'o" , Geert Uytterhoeven , Rasmus Villemoes , joe@perches.com, Arnd Bergmann , asmadeus@codewreck.org, Stefan Agner , Luc Van Oostenryck , Andrew Morton , Linus Torvalds , linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org, linux-sparse@vger.kernel.org, Linux Kbuild mailing list Subject: Re: [PATCH 0/2] Compiler Attributes: __fallthrough Message-ID: <20181023054306.wbmcg6vigc4jlb25@mwanda> References: <20181021171414.22674-1-miguel.ojeda.sandonis@gmail.com> <20181021182926.GB6683@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9054 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810230050 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 22, 2018 at 09:54:27AM -0700, Nick Desaulniers wrote: > On Mon, Oct 22, 2018 at 2:48 AM Miguel Ojeda > wrote: > > > > On Sun, Oct 21, 2018 at 8:29 PM Greg Kroah-Hartman > > wrote: > > > > > > Will this work with all of the static tools that are currently looking > > > for the comment instead? I know coverity handles that, what about > > > others? > > > > I will also contact the different tools about this. > > Let's contact the authors of these tools if they don't parse the > attribute. I prefer to have the attributes rather than specifically > formatted comments. > > I do think this may be tricky to provide backwards support for though; > Miguel, do you have info on which versions of GCC support comments vs > attribute? None. GCC 7.1 added support for the warning, the comment parsing and the attribute so it's fine. The only thing that we know for sure is an issue is Eclipse. We need to test Coverity but it should work in theory. And we don't know about CPPcheck. regards, dan carpenter