From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Maksym Kokhan <maksym.kokhan@globallogic.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Daniel Walker <dwalker@fifo99.com>,
Daniel Walker <danielwa@cisco.com>,
Andrii Bordunov <aborduno@cisco.com>,
Ruslan Bilovol <rbilovol@cisco.com>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH 5/8] arm: convert to generic builtin command line
Date: Wed, 24 Oct 2018 10:16:00 +0100 [thread overview]
Message-ID: <20181024091600.GT30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1538067393-5926-1-git-send-email-maksym.kokhan@globallogic.com>
On Thu, Sep 27, 2018 at 07:56:33PM +0300, Maksym Kokhan wrote:
> From: Daniel Walker <danielwa@cisco.com>
>
> This updates the arm 32bit code to use the CONFIG_GENERIC_CMDLINE
> option.
Sorry, I can't accept this change. While it may seem to be a good idea
to unify this between different architectures, the problem this presents
is that it breaks people's existing .config, and almost every single
defconfig that we have in arch/arm/configs/
The breakage is such that it will end up wiping out (eg) the setting of
CONFIG_CMDLINE entirely, and only if it's realised and retrieved
immediately from .config.old, it will be lost.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
prev parent reply other threads:[~2018-10-24 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 16:56 Maksym Kokhan
2018-10-24 9:16 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024091600.GT30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=aborduno@cisco.com \
--cc=ard.biesheuvel@linaro.org \
--cc=danielwa@cisco.com \
--cc=dwalker@fifo99.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maksym.kokhan@globallogic.com \
--cc=rbilovol@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®