From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B097DECDE44 for ; Wed, 24 Oct 2018 16:58:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A216207DD for ; Wed, 24 Oct 2018 16:58:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A216207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726759AbeJYB1B convert rfc822-to-8bit (ORCPT ); Wed, 24 Oct 2018 21:27:01 -0400 Received: from mail.bootlin.com ([62.4.15.54]:50099 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726433AbeJYB1B (ORCPT ); Wed, 24 Oct 2018 21:27:01 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 2E1972079D; Wed, 24 Oct 2018 18:58:09 +0200 (CEST) Received: from localhost (unknown [185.7.230.213]) by mail.bootlin.com (Postfix) with ESMTPSA id E4BD72075C; Wed, 24 Oct 2018 18:57:58 +0200 (CEST) Date: Wed, 24 Oct 2018 17:57:59 +0100 From: Maxime Ripard To: Paul Kocialkowski Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Mark Rutland , Chen-Yu Tsai , Thierry Reding , David Airlie , linux-sunxi@googlegroups.com, Mark Van den Borre , Gerry Demaret , Luc Verhaegen Subject: Re: [PATCH 2/4] drm/panel: simple: Add support for the Lemaker BL035 3.5" LCD Message-ID: <20181024165759.k6cnxyzgpiiuaigs@flea> References: <20181010114134.8211-1-contact@paulk.fr> <20181010114134.8211-2-contact@paulk.fr> <20181010145850.krwe7wlqkbcpja33@flea> <30178c8b263656a9c285e45c78e1908927c99c48.camel@paulk.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <30178c8b263656a9c285e45c78e1908927c99c48.camel@paulk.fr> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 23, 2018 at 12:08:17PM +0200, Paul Kocialkowski wrote: > Hi, > > Le mercredi 10 octobre 2018 à 16:58 +0200, Maxime Ripard a écrit : > > On Wed, Oct 10, 2018 at 01:41:32PM +0200, Paul Kocialkowski wrote: > > > This adds support for the 3.5" LCD panel from Lemaker, sold for use with > > > BananaPi boards. It comes with a 24-bit RGB888 parallel interface and > > > requires an active-low DE signal > > > > > > Signed-off-by: Paul Kocialkowski > > > --- > > > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > > index 97964f7f2ace..229080fcf65e 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -1461,6 +1461,30 @@ static const struct panel_desc kyo_tcg121xglp = { > > > .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > > > }; > > > > > > +static const struct drm_display_mode lemaker_bl035_mode = { > > > + .clock = 7000, > > > + .hdisplay = 320, > > > + .hsync_start = 320 + 20, > > > + .hsync_end = 320 + 20 + 30, > > > + .htotal = 320 + 20 + 30 + 38, > > > + .vdisplay = 240, > > > + .vsync_start = 240 + 4, > > > + .vsync_end = 240 + 4 + 3, > > > + .vtotal = 240 + 4 + 3 + 15, > > > + .vrefresh = 60, > > > +}; > > > + > > > +static const struct panel_desc lemaker_bl035 = { > > > + .modes = &lemaker_bl035_mode, > > > + .num_modes = 1, > > > + .size = { > > > + .width = 70, > > > + .height = 52, > > > + }, > > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > > > + .bus_flags = DRM_BUS_FLAG_DE_LOW, > > > +}; > > > + > > > static const struct drm_display_mode lg_lb070wv8_mode = { > > > .clock = 33246, > > > .hdisplay = 800, > > > @@ -2456,6 +2480,9 @@ static const struct of_device_id platform_of_match[] = { > > > }, { > > > .compatible = "kyo,tcg121xglp", > > > .data = &kyo_tcg121xglp, > > > + }, { > > > + .compatible = "lemaker,bl035", > > > + .data = &lemaker_bl035, > > > > You should document that new compatible. Also, where is this name > > coming from? Is it the name it's sold under? something you came up > > with? > > Oh right, I forgot to document the compatible (and add the new vendor). > > The name "BL035" comes from the PCB itself, where it reads "BL035-RGB- > 002" under the Lemaker logo. I went for "BL035" to keep it short. > > The latter part seems to be the PCB revision. According to the fex > files[0], the timings are the same for all the screens of the same size > (regardless of revision), so that revision probably shouldn't be in the > panel name. > > As for the "RGB" part, Lemaker only makes 3.5 and 5 inch LCDs with a > parallel RGB interface and 7 and 10.1 inch LCDs with LVDS, so there is > no ambiguity for now. > > Do you think it makes sense to keep that part in the panel name > nevertheless? I'd just put the full reference, to be on the safe side. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com