From: thesven73@gmail.com
To: svendev@arcx.com, p.zabel@pengutronix.de, denis@eukrea.com,
rmk+kernel@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [RFC v1 1/1] imx-drm: match ipu_di_signal_cfg's clk_pol with its observed behaviour.
Date: Thu, 25 Oct 2018 12:17:11 -0400 [thread overview]
Message-ID: <20181025161711.13727-2-TheSven73@googlemail.com> (raw)
In-Reply-To: <20181025161711.13727-1-TheSven73@googlemail.com>
From: Sven Van Asbroeck <svendev@arcx.com>
We used an oscilloscope to observe the actual polarity of the
DI's pixel clock, and saw the following:
DI_GENERAL bit 17 is SET:
pixel data is stable on the pixel clock's FALLING edge
DI_GENERAL bit 17 is CLEAR:
pixel data is stable on the pixel clock's RISING edge
However, the current driver configures the exact opposite of the
behaviour documented in video/imx-ipu-v3.h:
unsigned clk_pol:1; /* true = rising edge */
Fixes: 85de9d17c485c4196f74 ("imx-drm: match ipu_di_signal_cfg's clk_pol with its description.")
Signed-off-by: Sven Van Asbroeck <svendev@arcx.com>
---
drivers/gpu/ipu-v3/ipu-di.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c
index d2f1bd9d3deb..f296fa461875 100644
--- a/drivers/gpu/ipu-v3/ipu-di.c
+++ b/drivers/gpu/ipu-v3/ipu-di.c
@@ -619,7 +619,7 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig)
if (sig->mode.flags & DISPLAY_FLAGS_VSYNC_HIGH)
di_gen |= ipu_di_gen_polarity(sig->vsync_pin);
- if (sig->clk_pol)
+ if (!sig->clk_pol)
di_gen |= DI_GEN_POLARITY_DISP_CLK;
ipu_di_write(di, di_gen, DI_GENERAL);
--
2.17.1
next prev parent reply other threads:[~2018-10-25 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 16:17 [RFC v1 0/1] " thesven73
2018-10-25 16:17 ` thesven73 [this message]
2018-10-25 16:56 ` [RFC v1 1/1] " Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025161711.13727-2-TheSven73@googlemail.com \
--to=thesven73@gmail.com \
--cc=denis@eukrea.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=svendev@arcx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®