From: Muchun Song <smuchun@gmail.com>
To: mingo@kernel.org, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] sched/rt: Fix a comment in pick_next_task_rt()
Date: Sat, 27 Oct 2018 11:05:17 +0800 [thread overview]
Message-ID: <20181027030517.23292-1-smuchun@gmail.com> (raw)
Commit f4ebcbc0d7e0 ("sched/rt: Substract number of tasks of throttled
queues from rq->nr_running") added a new member rt_rq->rt_queued, which
is used to indicate the status of rq->rt enqueue or dequeue. So, the
check rt_nr_running was removed and we now check rt_queued.
Fix the comment in pick_next_task_rt() to avoid confusing.
Signed-off-by: Muchun Song <smuchun@gmail.com>
---
kernel/sched/rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 2e2955a8cf8f..a21ea6021929 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1561,7 +1561,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
/*
* We may dequeue prev's rt_rq in put_prev_task().
- * So, we update time before rt_nr_running check.
+ * So, we update time before rt_queued check.
*/
if (prev->sched_class == &rt_sched_class)
update_curr_rt(rq);
--
2.17.1
next reply other threads:[~2018-10-27 3:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 3:05 Muchun Song [this message]
2018-10-29 11:34 ` [tip:sched/urgent] sched/rt: Update " tip-bot for Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027030517.23292-1-smuchun@gmail.com \
--to=smuchun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®