From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A5FAC2BC61 for ; Tue, 30 Oct 2018 18:58:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 107D420823 for ; Tue, 30 Oct 2018 18:58:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 107D420823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stgolabs.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbeJaDwq (ORCPT ); Tue, 30 Oct 2018 23:52:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:37066 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727679AbeJaDwq (ORCPT ); Tue, 30 Oct 2018 23:52:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 04CADAB4D; Tue, 30 Oct 2018 18:58:03 +0000 (UTC) Date: Tue, 30 Oct 2018 11:57:56 -0700 From: Davidlohr Bueso To: Vito Caputo Cc: Waiman Long , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] fs/proc: introduce /proc/stat2 file Message-ID: <20181030185756.w3f2trelb7nikgmk@linux-r8p5> References: <20181029192521.23059-1-dave@stgolabs.net> <0afed890-7c5a-93ee-cdb9-e30775bd9cf1@redhat.com> <20181029200050.iejuxckzbm742dmw@linux-r8p5> <3c5ba85b-5114-c751-0114-ac2cb64c02ea@redhat.com> <20181029203818.pot26ewxbncfrnua@linux-r8p5> <20181029212314.nwruqg6au23ebqlu@shells.gnugeneration.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181029212314.nwruqg6au23ebqlu@shells.gnugeneration.com> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Oct 2018, Vito Caputo wrote: >I'm definitely not in favor of just adding another stat file that is the >same format as the existing one with the intrs zeroed out. It's a dirty >hack; fine for your local needs but too gross for upstream IMHO. I suspect very few users of /proc/stat actually use the irq fields in the first place. So the common case ends up doing unnecessary operations. The stat2 approach is not perfect, but I think it's the best approach so far. This sort of renaming is not uncommon when we cannot break userspace, and its not like procfs is not already far contaminated already. There are not enough users that care about this stuff, afaik. What you suggest sounds like a lot of over-engineering. Thanks, Davidlohr