From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7BDC0044C for ; Thu, 1 Nov 2018 19:10:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7C9C20657 for ; Thu, 1 Nov 2018 19:10:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7C9C20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbeKBEOc (ORCPT ); Fri, 2 Nov 2018 00:14:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:45926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbeKBEOc (ORCPT ); Fri, 2 Nov 2018 00:14:32 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C74820657; Thu, 1 Nov 2018 19:10:16 +0000 (UTC) Date: Thu, 1 Nov 2018 15:10:14 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org Subject: Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order Message-ID: <20181101151014.2feccd51@gandalf.local.home> In-Reply-To: <154108256792.2604.1816052586385217811.stgit@devbox> References: <154108256792.2604.1816052586385217811.stgit@devbox> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Nov 2018 23:29:28 +0900 Masami Hiramatsu wrote: > Fix strpbrk()'s argument order, it must pass acceptable string > in 2nd argument. Note that this can cause a kernel panic where > it recovers backup character to code->data. > > Fixes: a6682814f371 ("tracing/kprobes: Allow kprobe-events to record module symbol") > Signed-off-by: Masami Hiramatsu Thanks Masami, I'm pulling this and starting to test it. -- Steve > --- > kernel/trace/trace_probe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > index 3ef15a6683c0..bd30e9398d2a 100644 > --- a/kernel/trace/trace_probe.c > +++ b/kernel/trace/trace_probe.c > @@ -535,7 +535,7 @@ int traceprobe_update_arg(struct probe_arg *arg) > if (code[1].op != FETCH_OP_IMM) > return -EINVAL; > > - tmp = strpbrk("+-", code->data); > + tmp = strpbrk(code->data, "+-"); > if (tmp) > c = *tmp; > ret = traceprobe_split_symbol_offset(code->data,