From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA746ECDE46 for ; Thu, 1 Nov 2018 15:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1B7A20820 for ; Thu, 1 Nov 2018 15:50:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZfYs3I+f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1B7A20820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729080AbeKBAyM (ORCPT ); Thu, 1 Nov 2018 20:54:12 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44094 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727950AbeKBAyM (ORCPT ); Thu, 1 Nov 2018 20:54:12 -0400 Received: by mail-wr1-f67.google.com with SMTP id d17-v6so20222577wre.11; Thu, 01 Nov 2018 08:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FphGFWMz9ZX1okHPTKwCmEn+FB74CkRcVeC45nrUXks=; b=ZfYs3I+frSAOnBmZanu4iHP8B5X6Id2HdFJXPqjNXOly19kjhv8V2DbXFg4HtoZVLk iYE1Uhlk4J4LQA8698jmKj3WDNq3UZdrP3czCirpP8baDNbrIF75xJ2LMNkhyT10MjR9 s1HPkqEJPuiUxn3hpIaodqqa4WzOFlchMYEZfK6z6JxcViqO5Sra21Ggwe2//BGajhM7 Uk1702ZnzQPDOrIhZ6lO605lWV4hJgjy2CxUxSO2CG4LlQrGnjuwaBf0mwY1d/UEyRFv r7ZCl1fQQ8JZKtfo9h9WBI4C+rhedj86LOZEdKSSPk/UCkBIcbarnE2oQxRYL5ITMVkR HIPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FphGFWMz9ZX1okHPTKwCmEn+FB74CkRcVeC45nrUXks=; b=YnF1kThZsatEj1CyxR+ya5DCbRXYIaOm3oxuBhzq6lncn9v2ZEPAMthF7K0Q/RS8SE 4/fLQj1fIGna5iUCUCCIxVeqoRdy+jMKx8nX5XveqCv0J68qASeXjItWz66usqdaZuIo jlTlFZ/MTviQmaVwOj6hgNMfNJk8C/y3M5/g/1t5B+391dPBAZ/AOhKxbA2UPOkeUIvI vyltSJ3vpHeS/LxBbAKB65G9nL+44VMhdmk+sEf9zhZL89NoCO8Se9gCHgRqQUoVPedI kUJL//0rkYlSvB3AsqSUEtChtRyGmsr7CtrRRBi87Of3+Ahv2CqhsPl/w4JBazNDv2AF 1CXA== X-Gm-Message-State: AGRZ1gKHfaLgGM/GH9vkDL7ASEwxZyZn6HBFVLbhKlOkrNyE0tAgfsSJ fctSKU5SsYXDUDF/VZZwgoA= X-Google-Smtp-Source: AJdET5dh0z7v3LyQSir61SJ07BFp17fCI6wQulstkmaCt0ioqIT65A+f9DZvlGowfl3AHe1Bi91siA== X-Received: by 2002:adf:8b0a:: with SMTP id n10-v6mr6561757wra.282.1541087438577; Thu, 01 Nov 2018 08:50:38 -0700 (PDT) Received: from picard ([194.207.103.1]) by smtp.gmail.com with ESMTPSA id v11-v6sm1891522wrt.40.2018.11.01.08.50.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Nov 2018 08:50:37 -0700 (PDT) Date: Thu, 1 Nov 2018 15:50:36 +0000 From: Dean Wallace To: Hans de Goede Cc: Pierre-Louis Bossart , Andy Shevchenko , Stephen Boyd , Michael Turquette , linux-clk , Stable , Johannes Stezenbach , Andy Shevchenko , Linux Kernel Mailing List , Mogens Jensen Subject: Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL) Message-ID: <20181101155036.vkdrc7ajmkyd73o5@picard> References: <20181030161534.wk5cf7nxbwhp2far@picard> <307c2074-d268-a87a-6040-1240a2091a4d@redhat.com> <20181031200709.xrmu6wsdel7dtcjq@picard> <20181101103705.ay36te4qr5pxtgop@picard> <37e44480-44d3-9355-6119-ae46bb38678a@redhat.com> <20181101142859.oxtuhbwtt44h2u3r@picard> <67a7d54b-49cc-aa4e-fe47-bb6277f02bc8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <67a7d54b-49cc-aa4e-fe47-bb6277f02bc8@redhat.com> X-Info: Keep It Simple, Stupid. X-Operating-System: Linux, kernel 4.19.0-arch1-1-ARCH-dirty X-Message-Flag: WARNING!! Outlook sucks User-Agent: Every email client sucks, this one just sucks less. Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-11-18, Hans de Goede wrote: > Hi, > > On 01-11-18 15:28, Dean Wallace wrote: > > On 01-11-18, Hans de Goede wrote: > > > Hi, > > > > > > On 01-11-18 11:37, Dean Wallace wrote: > > > > On 31-10-18, Pierre-Louis Bossart wrote: > > > > > > > > > > > Just thought it worth mentioning, this new patch that fixes sound > > > > > > again, seems to have ressurected an old issue with PLL unlock. I'm > > > > > > seeing journal entries after fresh boot ...... > > > > > > > > > > > > ``` > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard systemd[462]: Started Sound Service. > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > picard kernel: max98090_pll_work: 141 callbacks suppressed > > > > > > picard kernel: max98090 i2c-193C9890:00: PLL unlocked > > > > > > ``` > > > > > > > > > > > > sound is ok, but sometimes plugging in headphones spams journal with > > > > > > those PLL messages, and sound turns into "daleks", and I have to > > > > > > remove/insert headphones few times or stop/start audio to fix it. > > > > > > It's a very old issue, maybe you'd know more about it. > > > > > > > > > > I noticed this error on my Orco device used for tests many moons ago, but I > > > > > could never find out what led to this error case, it wasn't deterministic > > > > > and didn't impact the audio quality. All I could do is rate_limit it... If > > > > > we have an A vs. B situation it'd be really helpful to diagnose further. > > > > > > > > > > Is there really a causality between the changes from Hans and this PLL > > > > > unlock error? Are you 100% sure this was not present in the previous install > > > > > you used (4.18.14 as mentioned earlier in the thread)? > > > > > > > > > > Thanks > > > > > > > > > > -Pierre > > > > > > > > > Well, numerous boots, kernels, headphone inserting - no PLL or > > > > 'Daleks'. My laptop must have been haunted that day (halloween). > > > > I'll put it to bed. > > > > > > So you can no longer reproduce. Bummer. Note this might be caused by > > > the temperature of the laptop when you were running the tests... > > > > > > Anyways if you hit this again and you can reproduce it, please > > > give adding a msleep(10) after code mucking with the clk a try. > > > > > > Regards, > > > > > > Hans > > > > > Right then, I can make it unlock and 'daleks' by going into > > pavucontrol and switching the Profile back and forth from Stereo > > Output to Stereo Output+Analog Mono Input, which is actually something > > I've done to make it correct itself as well. I don't use the mic or > > anything so I've had it set to Stereo Ouput only which I 'think' has > > somehow made it more stable for me. With all my playing around, one > > of the things I did was clean out my .config/pulse folder which meant > > by default the 'Profile' in pavucontrol was set to Output+Input, which > > seems to help trigger the PLL issue when inserting headphones. > > > > So what would you like me to do, as I can trigger it on demand it > > seems. > > Please give the attached patch a try (on top of my patch for the clk quirk) > and let us know if that fixes these errors. > > Regards, > > Hans > Sorry, it's not being consistent with me Now, fresh boot again, no errors in journal, no errors while plugging/unplugging earphones. I think it's definitely more stable with the profile in pavucontrol set to Output only (no + Input), but I can still trigger it by switching it, and it never corrects itself until I switch a few more times. -Dean