From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB51C0044C for ; Thu, 1 Nov 2018 18:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECF5920820 for ; Thu, 1 Nov 2018 18:56:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OaUH8Lma" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECF5920820 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726250AbeKBEAy (ORCPT ); Fri, 2 Nov 2018 00:00:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:43200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725722AbeKBEAy (ORCPT ); Fri, 2 Nov 2018 00:00:54 -0400 Received: from localhost (unknown [95.99.172.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA8BD205F4; Thu, 1 Nov 2018 18:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541098601; bh=1YWxeI45ZPNEUm3vGEtZVvCHQjvh1a4hNwnKrWoJV8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OaUH8LmaQJOPRns2Wk8+8rNwZASSF6ARjKRSO/gJ46cRFjmCmPIHXFaFnTunY9VoR iynxt5LV3yfe9qgyYfDrPOxJ+VMm7ba2CTddnH3JlH0Bxo6+/mW2DTCB3j/hxb5eiR 2s6M/YqZTFccf6zXchKLYZbT9PZWzRN+zMXUsXU4= Date: Thu, 1 Nov 2018 19:56:38 +0100 From: "gregkh@linuxfoundation.org" To: Dexuan Cui Cc: Michael Kelley , KY Srinivasan , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" , Stephen Hemminger , vkuznets , Sasha Levin , Haiyang Zhang , "Stable@vger.kernel.org" Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up Message-ID: <20181101185638.GB10263@kroah.com> References: <20181018050835.27828-1-kys@linuxonhyperv.com> <20181018050932.27932-1-kys@linuxonhyperv.com> <20181018050932.27932-3-kys@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote: > > From: Michael Kelley > > Sent: Wednesday, October 24, 2018 08:38 > > From: kys@linuxonhyperv.com Sent: Wednesday, > > October 17, 2018 10:10 PM > > > From: Dexuan Cui > > > > > > In kvp_send_key(), we do need call process_ib_ipinfo() if > > > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out > > > the userland hv_kvp_daemon needs the info of operation, adapter_id and > > > addr_family. With the incorrect fc62c3b1977d, the host can't get the > > > VM's IP via KVP. > > > > > > And, fc62c3b1977d added a "break;", but actually forgot to initialize > > > the key_size/value in the case of KVP_OP_SET, so the default key_size of > > > 0 is passed to the kvp daemon, and the pool files > > > /var/lib/hyperv/.kvp_pool_* can't be updated. > > > > > > This patch effectively rolls back the previous fc62c3b1977d, and > > > correctly fixes the "this statement may fall through" warnings. > > > > > > This patch is tested on WS 2012 R2 and 2016. > > > > > > Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall > > through" warnings") > > > Signed-off-by: Dexuan Cui > > > Cc: K. Y. Srinivasan > > > Cc: Haiyang Zhang > > > Cc: Stephen Hemminger > > > Cc: > > > Signed-off-by: K. Y. Srinivasan > > > --- > > > drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- > > > 1 file changed, 22 insertions(+), 4 deletions(-) > > > > > Reviewed-by: Michael Kelley > > Hi Greg, > Can you please take a look at this patch? Nope, I'm not the hv maintainer, they need to look at this and ack it, not me :) greg k-h