From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: "Theodore Ts'o" <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] drivers/char/random.c: make primary_crng static
Date: Fri, 2 Nov 2018 12:04:47 +0100 [thread overview]
Message-ID: <20181102110447.23121-3-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <20181102110447.23121-1-linux@rasmusvillemoes.dk>
Since the definition of struct crng_state is private to random.c, and
primary_crng is neither declared or used elsewhere, there's no reason
for that symbol to have external linkage.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/char/random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 1b2e1580b4b5..0a381897e4a5 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -415,7 +415,7 @@ struct crng_state {
spinlock_t lock;
};
-struct crng_state primary_crng = {
+static struct crng_state primary_crng = {
.lock = __SPIN_LOCK_UNLOCKED(primary_crng.lock),
};
--
2.19.1.6.gbde171bbf5
next prev parent reply other threads:[~2018-11-02 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 11:04 [PATCH 1/3] drivers/char/random.c: constify poolinfo_table Rasmus Villemoes
2018-11-02 11:04 ` [PATCH 2/3] drivers/char/random.c: remove unused stuct poolinfo::poolbits Rasmus Villemoes
2018-11-07 22:11 ` Theodore Y. Ts'o
2018-11-02 11:04 ` Rasmus Villemoes [this message]
2018-11-07 22:11 ` [PATCH 3/3] drivers/char/random.c: make primary_crng static Theodore Y. Ts'o
2018-11-07 22:11 ` [PATCH 1/3] drivers/char/random.c: constify poolinfo_table Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102110447.23121-3-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®