From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: arnd@arndb.de, gregkh@linuxfoundation.org
Cc: ulf.hansson@linaro.org, stern@rowland.harvard.edu,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: [PATCH 1/5 v7] memstick: rtsx_usb_ms: Add missing pm_runtime_disable() in probe function
Date: Mon, 5 Nov 2018 16:45:02 +0800 [thread overview]
Message-ID: <20181105084506.6476-2-kai.heng.feng@canonical.com> (raw)
In-Reply-To: <20181105084506.6476-1-kai.heng.feng@canonical.com>
If the probe fails, we should use pm_runtime_disable() to balance
pm_runtime_enable().
Add missing pm_runtime_disable() for rtsx_usb_ms.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/memstick/host/rtsx_usb_ms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c
index 4f64563df7de..e95e64974a91 100644
--- a/drivers/memstick/host/rtsx_usb_ms.c
+++ b/drivers/memstick/host/rtsx_usb_ms.c
@@ -770,6 +770,7 @@ static int rtsx_usb_ms_drv_probe(struct platform_device *pdev)
return 0;
err_out:
memstick_free_host(msh);
+ pm_runtime_disable(ms_dev(host));
return err;
}
--
2.19.1
next prev parent reply other threads:[~2018-11-05 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 8:45 [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card Kai-Heng Feng
2018-11-05 8:45 ` Kai-Heng Feng [this message]
2018-11-05 8:45 ` [PATCH 2/5 v7] misc: rtsx_usb: Use USB remote wakeup signaling for card insertion detection Kai-Heng Feng
2018-11-05 8:45 ` [PATCH 3/5 v7] memstick: Prevent memstick host from getting runtime suspended during card detection Kai-Heng Feng
2018-11-05 8:45 ` [PATCH 4/5 v7] memstick: rtsx_usb_ms: Use ms_dev() helper Kai-Heng Feng
2018-11-05 8:45 ` [PATCH 5/5 v7] memstick: rtsx_usb_ms: Support runtime power management Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105084506.6476-2-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®