From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFE5C0044C for ; Mon, 5 Nov 2018 14:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E57282085A for ; Mon, 5 Nov 2018 14:57:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E57282085A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729838AbeKFARn (ORCPT ); Mon, 5 Nov 2018 19:17:43 -0500 Received: from mga12.intel.com ([192.55.52.136]:49922 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbeKFARm (ORCPT ); Mon, 5 Nov 2018 19:17:42 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 06:57:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,468,1534834800"; d="scan'208";a="105409860" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 05 Nov 2018 06:57:34 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 05 Nov 2018 16:57:33 +0200 Date: Mon, 5 Nov 2018 16:57:33 +0200 From: Heikki Krogerus To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Mika Westerberg , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/4] device property: Introduce fwnode_name() Message-ID: <20181105145733.GA1777@kuha.fi.intel.com> References: <20181105091727.25544-1-heikki.krogerus@linux.intel.com> <20181105091727.25544-2-heikki.krogerus@linux.intel.com> <20181105143731.GK10650@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181105143731.GK10650@smile.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > +const char *fwnode_name(const struct fwnode_handle *fwnode) > > +{ > > + const char *name = fwnode_call_ptr_op(fwnode, name); > > + > > + if (!name) > > + fwnode_call_int_op(fwnode, property_read_string_array, > > + "name", &name, 1); > > Is it going to be extended in the future? > > Otherwise I would rather go with (few more LOCs, yes) > > const char *name; > > name = fwnode_call_ptr_op(fwnode, name); > if (name) > return name; > > fwnode_call_int_op(fwnode, property_read_string_array, "name", &name, 1); > return name; That does look better. I'll fix it. thanks, -- heikki