From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4874DC32789 for ; Tue, 6 Nov 2018 10:11:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B91B20862 for ; Tue, 6 Nov 2018 10:11:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B91B20862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387773AbeKFTfd (ORCPT ); Tue, 6 Nov 2018 14:35:33 -0500 Received: from mga14.intel.com ([192.55.52.115]:52477 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387480AbeKFTfd (ORCPT ); Tue, 6 Nov 2018 14:35:33 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2018 02:11:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,471,1534834800"; d="scan'208";a="89813630" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga008.jf.intel.com with ESMTP; 06 Nov 2018 02:11:00 -0800 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1gJyK2-0003Vt-Od; Tue, 06 Nov 2018 12:10:58 +0200 Date: Tue, 6 Nov 2018 12:10:58 +0200 From: Andy Shevchenko To: Arnd Bergmann Cc: Pierre-Louis Bossart , Takashi Iwai , ALSA Development Mailing List , guneshwor.o.singh@intel.com, naveen.m@intel.com, pankaj.laxminarayan.bharadiya@intel.com, rakesh.a.ughreja@intel.com, sanyog.r.kale@intel.com, sriramx.periyasamy@intel.com, Mark Brown , Vinod Koul , liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com, Linux Kernel Mailing List Subject: Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA Message-ID: <20181106101058.GQ10650@smile.fi.intel.com> References: <20181102112456.780127-1-arnd@arndb.de> <943d10e2-299c-4393-f2f5-4ac8bbe400c3@linux.intel.com> <20181105133545.GF10650@smile.fi.intel.com> <5c21e5d9-6a14-ff4f-04f2-9dbfc8665250@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 05, 2018 at 10:19:02PM +0100, Arnd Bergmann wrote: > On 11/5/18, Andy Shevchenko wrote: > > On Mon, Nov 5, 2018 at 7:19 PM Pierre-Louis Bossart > > wrote: > >> >> config SND_SOC_HDAC_HDA_FORCE > >> >> tristate > > > >> >> depends on SND_SOC_ALL_CODECS != n > > > > Forgot to mention that AFAIU above line is no-op in symbols which are > > hidden. > > > > It's not. In this case, it will prevent SND_SOC_HDAC_HDA_FORCE > from being turned on by the 'default ...' line. In other cases, it can > generate a warning if you have a hidden symbol that is selected > by some other symbol while the dependency is missing. Something new to learn. Thanks, Arnd, for describing this case. -- With Best Regards, Andy Shevchenko