From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269A2C32789 for ; Tue, 6 Nov 2018 12:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F05EE20869 for ; Tue, 6 Nov 2018 12:27:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F05EE20869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730483AbeKFVwi (ORCPT ); Tue, 6 Nov 2018 16:52:38 -0500 Received: from mga09.intel.com ([134.134.136.24]:48023 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729711AbeKFVwi (ORCPT ); Tue, 6 Nov 2018 16:52:38 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2018 04:27:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,471,1534834800"; d="scan'208";a="105693161" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 06 Nov 2018 04:27:35 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 06 Nov 2018 14:27:34 +0200 Date: Tue, 6 Nov 2018 14:27:34 +0200 From: Heikki Krogerus To: Andy Shevchenko Cc: Rob Herring , "Rafael J. Wysocki" , Mika Westerberg , "linux-kernel@vger.kernel.org" , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/4] of/property: Introduce of_fwnode_name() Message-ID: <20181106122734.GC13048@kuha.fi.intel.com> References: <20181105091727.25544-1-heikki.krogerus@linux.intel.com> <20181105091727.25544-4-heikki.krogerus@linux.intel.com> <20181106105803.GS10650@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181106105803.GS10650@smile.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 06, 2018 at 12:58:03PM +0200, Andy Shevchenko wrote: > On Mon, Nov 05, 2018 at 12:50:02PM -0600, Rob Herring wrote: > > On Mon, Nov 5, 2018 at 3:17 AM Heikki Krogerus > > wrote: > > > > +static const char *of_fwnode_name(const struct fwnode_handle *fwnode) > > > +{ > > > + return to_of_node(fwnode)->name; > > > > I'm trying to get rid of the DT name ptr, so please don't add one. You > > can use of_node_full_name() here instead if "@" > > instead of is fine. Otherwise, you've got to allocate your own > > storage and use "%pOFn" printf specifier. > > If we do this here, we will change a behaviour of the entire set of > of_fwnode_get_named_child_node() users. > > I think this is out of scope of the series. You have a point. We must use the same member that was used in of_fwnode_get_named_child_node(). The goal of this series if most likely not clear from this patch alone, so I'll send a second version and make sure to CC the DT list and Rob. But in any case, I'll keep this part as it is. thanks, -- heikki