From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
bp@alien8.de, namit@vmware.com, joe@perches.com,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
segher@kernel.crashing.org, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage
Date: Tue, 6 Nov 2018 20:59:20 +0100 [thread overview]
Message-ID: <20181106195920.GE9781@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAHk-=wgTKDiDiQzoH=-ho1bn_SqvxHg+SEy1tQ_dSqqJJB5Rcw@mail.gmail.com>
On Tue, Nov 06, 2018 at 11:51:35AM -0800, Linus Torvalds wrote:
> On Tue, Nov 6, 2018 at 11:42 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > Do you want me to do that patch, or have you already just done it?
>
> I'd rather see it go through something like -tip than doing it myself
> directly, and get at least some of the automated testing before
> unleashing it on an unsuspecting world.
>
> I don't think it will affect much, but there *could* be situations
> where there are some crusty __inline__ users that actually want
> __always_inline behavior.
>
> And we *may* actually have cases where we want the "let compiler make
> a judgement call" behavior, so with this change people will have that
> as an option. But yes, in the short term, it has the possibility of
> regressions due to missed inlining.
Fair enough; I'll do the patch and let it soak a bit in tip.
Thanks!
prev parent reply other threads:[~2018-11-06 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 10:02 Peter Zijlstra
2018-11-06 14:09 ` Miguel Ojeda
2018-11-06 14:46 ` Peter Zijlstra
2018-11-06 17:21 ` Miguel Ojeda
2018-11-06 19:18 ` Linus Torvalds
2018-11-06 19:41 ` Peter Zijlstra
2018-11-06 19:51 ` Linus Torvalds
2018-11-06 19:59 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106195920.GE9781@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=namit@vmware.com \
--cc=segher@kernel.crashing.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®