From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FC4C32789 for ; Thu, 8 Nov 2018 08:12:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E567E2081C for ; Thu, 8 Nov 2018 08:12:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E567E2081C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726758AbeKHRqw (ORCPT ); Thu, 8 Nov 2018 12:46:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:34228 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726162AbeKHRqw (ORCPT ); Thu, 8 Nov 2018 12:46:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 56DB7AD08; Thu, 8 Nov 2018 08:12:32 +0000 (UTC) Date: Thu, 8 Nov 2018 09:12:31 +0100 From: Michal Hocko To: Anshuman Khandual , Andrew Morton Cc: linux-mm@kvack.org, Oscar Salvador , Baoquan He , LKML Subject: Re: [RFC PATCH 5/5] mm, memory_hotplug: be more verbose for memory offline failures Message-ID: <20181108081231.GN27423@dhcp22.suse.cz> References: <20181107101830.17405-1-mhocko@kernel.org> <20181107101830.17405-6-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 08-11-18 12:46:47, Anshuman Khandual wrote: > > > On 11/07/2018 03:48 PM, Michal Hocko wrote: [...] > > @@ -1411,8 +1409,14 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > /* Allocate a new page from the nearest neighbor node */ > > ret = migrate_pages(&source, new_node_page, NULL, 0, > > MIGRATE_SYNC, MR_MEMORY_HOTPLUG); > > - if (ret) > > + if (ret) { > > + list_for_each_entry(page, &source, lru) { > > + pr_warn("migrating pfn %lx failed ", > > + page_to_pfn(page), ret); > > Seems like pr_warn() needs to have %d in here to print 'ret'. Dohh. Rebase hickup. You are right ret:%d got lost on the way. > Though > dumping return code from migrate_pages() makes sense, wondering if > it is required for each and every page which failed to migrate here > or just one instance is enough. Does it matter enough to special case one printk? > > + dump_page(page, NULL); > > + } > > s/NULL/failed to migrate/ for dump_page(). Yes, makes sense. > > > putback_movable_pages(&source); > > + } > > } > > out: > > return ret; > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index a919ba5cb3c8..23267767bf98 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -7845,6 +7845,7 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count, > > return false; > > unmovable: > > WARN_ON_ONCE(zone_idx(zone) == ZONE_MOVABLE); > > + dump_page(pfn_to_page(pfn+iter), "has_unmovable_pages"); > > s/has_unmovable_pages/is unmovable/ OK > If we eally care about the function name, then dump_page() should be > followed by dump_stack() like the case in some other instances. > > > return true; > > This will be dumped from HugeTLB and CMA allocation paths as well through > alloc_contig_range(). But it should be okay as those occurrences should be > rare and dumping page state then will also help. yes Thanks and here is the incremental fix: diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index bf214beccda3..820397e18e59 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1411,9 +1411,9 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) MIGRATE_SYNC, MR_MEMORY_HOTPLUG); if (ret) { list_for_each_entry(page, &source, lru) { - pr_warn("migrating pfn %lx failed ", + pr_warn("migrating pfn %lx failed ret:%d ", page_to_pfn(page), ret); - dump_page(page, NULL); + dump_page(page, "migration failure"); } putback_movable_pages(&source); } diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 23267767bf98..ec2c7916dc2d 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7845,7 +7845,7 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count, return false; unmovable: WARN_ON_ONCE(zone_idx(zone) == ZONE_MOVABLE); - dump_page(pfn_to_page(pfn+iter), "has_unmovable_pages"); + dump_page(pfn_to_page(pfn+iter), "unmovable page"); return true; } -- Michal Hocko SUSE Labs