mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Yi Wang <wang.yi59@zte.com.cn>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn
Subject: Re: [PATCH] sched/fair: make some function static
Date: Thu, 8 Nov 2018 11:37:43 +0100	[thread overview]
Message-ID: <20181108103743.GQ9761@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1541656452-3326-1-git-send-email-wang.yi59@zte.com.cn>

On Thu, Nov 08, 2018 at 01:54:12PM +0800, Yi Wang wrote:
> Make some function static as they are not used outside of fair.c.
> 
> This fixes the following warning when building with 'W=1':
> 
> kernel/sched/fair.c:2439:6: warning: no previous prototype for ‘task_numa_work’ [-Wmissing-prototypes]
> kernel/sched/fair.c:2584:6: warning: no previous prototype for ‘task_tick_numa’ [-Wmissing-prototypes]
> kernel/sched/fair.c:3548:6: warning: no previous prototype for ‘sync_entity_load_avg’ [-Wmissing-prototypes]
> kernel/sched/fair.c:3561:6: warning: no previous prototype for ‘remove_entity_load_avg’ [-Wmissing-prototypes]
> 
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>

I'm not sure why; but when I apply I get:

$ quilt push
Applying patch patches/yi_wang-sched_fair-make_some_function_static.patch
patching file kernel/sched/fair.c
Hunk #1 FAILED at 2436.
Hunk #2 FAILED at 2581.
Hunk #3 FAILED at 3545.
Hunk #4 FAILED at 3558.
4 out of 4 hunks FAILED -- rejects in file kernel/sched/fair.c
Patch patches/yi_wang-sched_fair-make_some_function_static.patch does not apply (enforce with -f)D

      reply	other threads:[~2018-11-08 11:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08  5:54 Yi Wang
2018-11-08 10:37 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108103743.GQ9761@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=wang.yi59@zte.com.cn \
    --cc=zhong.weidong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®