From: Kyle Roeschley <kyle.roeschley@ni.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S . Miller" <davem@davemloft.net>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Kyle Roeschley <kyle.roeschley@ni.com>
Subject: [PATCH 2/3] ath6kl: Fix off by one error in scan completion
Date: Thu, 8 Nov 2018 10:36:58 -0600 [thread overview]
Message-ID: <20181108163659.19535-2-kyle.roeschley@ni.com> (raw)
In-Reply-To: <20181108163659.19535-1-kyle.roeschley@ni.com>
When ath6kl was reworked to share code between regular and scheduled scans
in commit 3b8ffc6a22ba ("ath6kl: Configure probed SSID list consistently"),
probed SSID entry changed from 1-index to 0-indexed. However,
ath6kl_cfg80211_scan_complete_event() was missed in that change. Fix its
indexing so that we correctly clear out the probed SSID list.
Signed-off-by: Kyle Roeschley <kyle.roeschley@ni.com>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 6c98d7903ffb..d7c626d9594e 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -1093,7 +1093,7 @@ void ath6kl_cfg80211_scan_complete_event(struct ath6kl_vif *vif, bool aborted)
if (vif->scan_req->n_ssids && vif->scan_req->ssids[0].ssid_len) {
for (i = 0; i < vif->scan_req->n_ssids; i++) {
ath6kl_wmi_probedssid_cmd(ar->wmi, vif->fw_vif_idx,
- i + 1, DISABLE_SSID_FLAG,
+ i, DISABLE_SSID_FLAG,
0, NULL);
}
}
--
2.19.1
next prev parent reply other threads:[~2018-11-08 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 16:36 [PATCH 1/3] ath6kl: Only use match sets when firmware supports it Kyle Roeschley
2018-11-08 16:36 ` Kyle Roeschley [this message]
2018-11-08 16:36 ` [PATCH 3/3] ath6kl: Use debug instead of error message when disabled Kyle Roeschley
2018-11-30 20:16 ` [PATCH 1/3] ath6kl: Only use match sets when firmware supports it Kyle Roeschley
2018-12-03 8:41 ` Kalle Valo
2018-12-03 15:27 ` Kyle Roeschley
2018-12-20 7:31 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108163659.19535-2-kyle.roeschley@ni.com \
--to=kyle.roeschley@ni.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®