From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FF2ECDE47 for ; Thu, 8 Nov 2018 20:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1559820840 for ; Thu, 8 Nov 2018 20:27:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tnMWPxQ2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1559820840 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727366AbeKIGEU (ORCPT ); Fri, 9 Nov 2018 01:04:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:48844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725723AbeKIGEU (ORCPT ); Fri, 9 Nov 2018 01:04:20 -0500 Received: from localhost (unknown [104.132.0.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26D0E206BA; Thu, 8 Nov 2018 20:27:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541708834; bh=hU3eyLPUfBm8DRJuOwjA/Laztv+c5H3c5FB7+MQhafM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tnMWPxQ2lhLwrT4vaUXcCYTdPkJcKByAwUwCzHuda1Si7Hz04h2WAaoDUFhWM7Os7 txXUmPmIcdi8VWW/e3isv6JjgtC2cKuKjV+eaeBS7CHYa3/3YW1erMaiZE6f93Eb/2 ZNHnPfhWhv9Q0xneUNbx7oJRmaD/wO41X2HFN02U= Date: Thu, 8 Nov 2018 12:27:13 -0800 From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: stable@vger.kernel.org Subject: Re: [PATCH] f2fs: wait writeback before reading data to avoid stale encrypted block Message-ID: <20181108202713.GA9862@jaegeuk-macbookpro.roam.corp.google.com> References: <20181107024639.41771-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181107024639.41771-1-jaegeuk@kernel.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let me drop this, since I missed there was a patch to introdcued this. :) On 11/06, Jaegeuk Kim wrote: > If background GC is running very frequently by gc_urgent, the next GC > can see unwritten data generated by the previous GC, which incurs to write > stale corrupted data in disk. > > Cc: > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index a07241fb8537..49fea136a3f3 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -658,6 +658,9 @@ static int ra_data_block(struct inode *inode, pgoff_t index) > fio.page = page; > fio.new_blkaddr = fio.old_blkaddr = dn.data_blkaddr; > > + /* wait writeback before reading out */ > + f2fs_wait_on_block_writeback(inode, dn.data_blkaddr); > + > fio.encrypted_page = f2fs_pagecache_get_page(META_MAPPING(sbi), > dn.data_blkaddr, > FGP_LOCK | FGP_CREAT, GFP_NOFS); > @@ -755,6 +758,9 @@ static int move_data_block(struct inode *inode, block_t bidx, > fio.page = page; > fio.new_blkaddr = fio.old_blkaddr = dn.data_blkaddr; > > + /* wait writeback before reading out */ > + f2fs_wait_on_block_writeback(inode, fio.old_blkaddr); > + > if (lfs_mode) > down_write(&fio.sbi->io_order_lock); > > -- > 2.19.0.605.g01d371f741-goog