From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>
Subject: [PATCH V8 09/18] block: introduce bio_bvecs()
Date: Sat, 10 Nov 2018 00:26:01 +0800 [thread overview]
Message-ID: <20181109162610.18981-10-ming.lei@redhat.com> (raw)
In-Reply-To: <20181109162610.18981-1-ming.lei@redhat.com>
There are still cases in which we need to use bio_bvecs() for get the
number of multi-page segment, so introduce it.
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
include/linux/bio.h | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 1f0dcf109841..3496c816946e 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -196,7 +196,6 @@ static inline unsigned bio_segments(struct bio *bio)
* We special case discard/write same/write zeroes, because they
* interpret bi_size differently:
*/
-
switch (bio_op(bio)) {
case REQ_OP_DISCARD:
case REQ_OP_SECURE_ERASE:
@@ -205,13 +204,34 @@ static inline unsigned bio_segments(struct bio *bio)
case REQ_OP_WRITE_SAME:
return 1;
default:
- break;
+ bio_for_each_segment(bv, bio, iter)
+ segs++;
+ return segs;
}
+}
- bio_for_each_segment(bv, bio, iter)
- segs++;
+static inline unsigned bio_bvecs(struct bio *bio)
+{
+ unsigned bvecs = 0;
+ struct bio_vec bv;
+ struct bvec_iter iter;
- return segs;
+ /*
+ * We special case discard/write same/write zeroes, because they
+ * interpret bi_size differently:
+ */
+ switch (bio_op(bio)) {
+ case REQ_OP_DISCARD:
+ case REQ_OP_SECURE_ERASE:
+ case REQ_OP_WRITE_ZEROES:
+ return 0;
+ case REQ_OP_WRITE_SAME:
+ return 1;
+ default:
+ bio_for_each_bvec(bv, bio, iter)
+ bvecs++;
+ return bvecs;
+ }
}
/*
--
2.9.5
next prev parent reply other threads:[~2018-11-09 16:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 16:25 [PATCH V8 00/18] block: support multi-page bvec Ming Lei
2018-11-09 16:25 ` [PATCH V8 01/18] block: introduce multi-page page bvec helpers Ming Lei
2018-11-09 16:25 ` [PATCH V8 02/18] block: introduce bio_for_each_bvec() Ming Lei
2018-11-09 16:25 ` [PATCH V8 03/18] block: use bio_for_each_bvec() to compute multi-page bvec count Ming Lei
2018-11-09 16:25 ` [PATCH V8 04/18] block: use bio_for_each_bvec() to map sg Ming Lei
2018-11-09 16:25 ` [PATCH V8 05/18] block: introduce bvec_last_segment() Ming Lei
2018-11-09 16:25 ` [PATCH V8 06/18] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-11-09 16:25 ` [PATCH V8 07/18] btrfs: use bvec_last_segment to get bio's last page Ming Lei
2018-11-09 16:26 ` [PATCH V8 08/18] btrfs: move bio_pages_all() to btrfs Ming Lei
2018-11-09 16:26 ` Ming Lei [this message]
2018-11-09 16:26 ` [PATCH V8 10/18] block: loop: pass multi-page bvec to iov_iter Ming Lei
2018-11-09 16:26 ` [PATCH V8 11/18] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2018-11-09 16:26 ` [PATCH V8 12/18] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Ming Lei
2018-11-09 16:26 ` [PATCH V8 13/18] block: enable multipage bvecs Ming Lei
2018-11-13 11:39 ` Ming Lei
2018-11-09 16:26 ` [PATCH V8 14/18] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-11-09 16:26 ` [PATCH V8 15/18] block: document usage of bio iterator helpers Ming Lei
2018-11-09 16:26 ` [PATCH V8 16/18] block: don't use bio->bi_vcnt to figure out segment number Ming Lei
2018-11-09 16:26 ` [PATCH V8 17/18] block: kill QUEUE_FLAG_NO_SG_MERGE Ming Lei
2018-11-09 16:26 ` [PATCH V8 18/18] block: kill BLK_MQ_F_SG_MERGE Ming Lei
2018-11-09 19:44 ` [PATCH V8 00/18] block: support multi-page bvec Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109162610.18981-10-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®