From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAECFC43441 for ; Thu, 15 Nov 2018 13:09:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 838E620815 for ; Thu, 15 Nov 2018 13:09:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 838E620815 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388146AbeKOXQz (ORCPT ); Thu, 15 Nov 2018 18:16:55 -0500 Received: from mail.bootlin.com ([62.4.15.54]:40237 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729024AbeKOXQz (ORCPT ); Thu, 15 Nov 2018 18:16:55 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 7798820D73; Thu, 15 Nov 2018 14:09:06 +0100 (CET) Received: from bbrezillon (aaubervilliers-681-1-13-146.w90-88.abo.wanadoo.fr [90.88.134.146]) by mail.bootlin.com (Postfix) with ESMTPSA id F09B020746; Thu, 15 Nov 2018 14:09:05 +0100 (CET) Date: Thu, 15 Nov 2018 14:09:05 +0100 From: Boris Brezillon To: Miquel Raynal Cc: Liang Yang , Rob Herring , Hanjie Lin , Victor Wan , Jianxin Pan , Neil Armstrong , Martin Blumenstingl , Richard Weinberger , Yixun Lan , , Marek Vasut , Jian Hu , , Kevin Hilman , Carlo Caione , , Brian Norris , David Woodhouse , , Jerome Brunet , Wolfram Sang Subject: Re: [PATCH v6 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller Message-ID: <20181115140905.40011b4b@bbrezillon> In-Reply-To: <20181115140400.3934effe@xps13> References: <1541090542-19618-1-git-send-email-jianxin.pan@amlogic.com> <1541090542-19618-3-git-send-email-jianxin.pan@amlogic.com> <20181105165321.7ea2b45f@bbrezillon> <20181106102851.61deb97a@bbrezillon> <20181106112206.65a70a81@bbrezillon> <20181112171351.4ac3506b@xps13> <20181112175416.247e3203@bbrezillon> <20181112184518.6c02ac6d@bbrezillon> <27769252-ac5e-e787-6792-d6a06e7af0e4@amlogic.com> <20181115140400.3934effe@xps13> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Nov 2018 14:04:00 +0100 Miquel Raynal wrote: > Hi Liang, > > Liang Yang wrote on Thu, 15 Nov 2018 19:25:07 > +0800: > > > Hi Boris, > > > > I have implemented dma access base on these helpers you provided below. > > we prepare to send v7 version now, so when will these helpers be pushed? > > Thanks for your work. You can send the v7 so we will have a look at the > overall driver; but since we raised the DMA buffers issue we had a > discussion with Boris about how to handle them and I think we are going > to adopt the same solution as Wolfram in the I2C subsystem: manual > flagging. Sadly, this is probably the best we can do to ensure proper > DMA support. > > There is nothing set is stone yet but I started a small rework to > handle MTD operations differently (and add a DMA_SAFE flag), you can > have a look there [1]. Don't base your work on it for now as it is just > a preliminary version, subject to big changes. In order to not block the driver, I'd suggest that you move the helper I proposed directly into your driver and prefix them with 'meson_'.