From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Borislav Petkov" <bp@alien8.de>,
pr-tracker-bot@kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Thomas Lendacky" <Thomas.Lendacky@amd.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Martin Hundebøll" <martin@geanix.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Len Brown" <lenb@kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: [GIT PULL] PCI fixes for v4.20
Date: Thu, 15 Nov 2018 13:13:07 -0500 [thread overview]
Message-ID: <20181115181307.GA25806@pure.paranoia.local> (raw)
In-Reply-To: <20181115172706.GA229449@google.com>
On Thu, Nov 15, 2018 at 11:27:06AM -0600, Bjorn Helgaas wrote:
> > > OK, I think I'll remove the insteadOf chunk from my .gitconfig. Should
> > > https://korg.wiki.kernel.org/userdoc/gitolite be updated to remove or
> > > expand that recommendation? The only reason I added insteadOf in the first
> > > place was because it sounded like a security improvement.
> >
> > It is. Does adding the insteadOf rules result in ssh:// URLs when using
> > git-request-pull? I didn't expect that it would.
>
> Yep, it seems to for me. Maybe I'm doing something else weird, because I
> don't see many other pull requests with ssh:// URLs.
Hmm, you're right -- I just tested this and it does. I can't imagine
that's the intended effect of insteadOf -- it's supposed to alter URLs
behind the scenes, not permanently transform them. I'll talk to git
folks about it.
For now, you should probably remove that from your gitconfig so that
your pull requests have public URLs in them.
Best,
-K
next prev parent reply other threads:[~2018-11-15 18:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 6:20 Bjorn Helgaas
2018-11-14 20:00 ` pr-tracker-bot
2018-11-14 20:12 ` Borislav Petkov
2018-11-14 20:16 ` Konstantin Ryabitsev
2018-11-14 21:46 ` Borislav Petkov
2018-11-14 22:21 ` Konstantin Ryabitsev
2018-11-14 22:48 ` Borislav Petkov
2018-11-15 7:12 ` Bjorn Helgaas
2018-11-15 7:53 ` Konstantin Ryabitsev
2018-11-15 15:03 ` Bjorn Helgaas
2018-11-15 15:54 ` Konstantin Ryabitsev
2018-11-15 17:27 ` Bjorn Helgaas
2018-11-15 18:08 ` Borislav Petkov
2018-11-15 18:13 ` Konstantin Ryabitsev [this message]
2018-12-01 5:59 Bjorn Helgaas
2018-12-01 20:05 ` pr-tracker-bot
2018-12-07 20:44 Bjorn Helgaas
2018-12-07 21:10 ` pr-tracker-bot
2018-12-18 21:40 Bjorn Helgaas
2018-12-18 23:55 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115181307.GA25806@pure.paranoia.local \
--to=konstantin@linuxfoundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Thomas.Lendacky@amd.com \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=martin@geanix.com \
--cc=mingo@kernel.org \
--cc=pr-tracker-bot@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®