mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: chouryzhou <chouryzhou@tencent.com>,
	"tkjos@google.com" <tkjos@google.com>,
	"arve@android.com" <arve@android.com>,
	"tkjos@android.com" <tkjos@android.com>,
	"dave@stgolabs.net" <dave@stgolabs.net>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4] binder: ipc namespace support for android binder
Date: Thu, 15 Nov 2018 14:54:27 -0800	[thread overview]
Message-ID: <20181115225427.GA25874@kroah.com> (raw)
In-Reply-To: <20181115143349.44e1942213b61a4818bcbf02@linux-foundation.org>

On Thu, Nov 15, 2018 at 02:33:49PM -0800, Andrew Morton wrote:
> On Mon, 12 Nov 2018 09:37:51 +0000 chouryzhou(周威) <chouryzhou@tencent.com> wrote:
> 
> > Currently android's binder is not isolated by ipc namespace. Since binder 
> > is a form of IPC and therefore should be tied to ipc namespace. With this 
> > patch, we can run multiple instances of  android container on one host.
> > 
> > This patch move "binder_procs" and "binder_context" into ipc_namespace,
> > driver will find the context from it when opening. For debugfs, binder_proc
> > is namespace-aware, but not for binder dead nodes, binder_stats and 
> > binder_transaction_log_entry (we added ipc inum to trace it).
> > 
> > ...
> >
> >  drivers/android/binder.c      | 133 ++++++++++++++++++++++++++++++++----------
> >  include/linux/ipc_namespace.h |  15 +++++
> >  ipc/namespace.c               |  10 +++-
> >  3 files changed, 125 insertions(+), 33 deletions(-)
> 
> Well, it's mainly an android patch so I suggest this be taken via the
> android tree.
> 
> Acked-by: Andrew Morton <akpm@linux-foundation.org>
> 

A number of us have talked about this in the plumbers Android track, and
a different proposal for how to solve this has been made that should be
much more resiliant.  So I will drop this patch from my queue and wait
for the patches based on the discussions we had there.

I think there's some notes/slides on the discussion online somewhere,
but it hasn't been published as the conference is still happening,
otherwise I would link to it here...

thanks,

greg k-h

  reply	other threads:[~2018-11-15 22:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  9:37 chouryzhou(周威)
2018-11-12 16:45 ` Todd Kjos
2018-11-12 19:24   ` Christian Brauner
2018-11-15 22:33 ` Andrew Morton
2018-11-15 22:54   ` gregkh [this message]
2018-11-16 19:19     ` Todd Kjos
2018-11-20  0:23       ` Christian Brauner
2018-11-13  8:12 chouryzhou(周威)
2018-11-13 16:10 ` Todd Kjos
2018-11-20  3:56 chouryzhou(周威)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115225427.GA25874@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=arve@android.com \
    --cc=chouryzhou@tencent.com \
    --cc=dave@stgolabs.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tkjos@android.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®