From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17EDAC43441 for ; Fri, 16 Nov 2018 12:00:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBB4120869 for ; Fri, 16 Nov 2018 12:00:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBB4120869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389632AbeKPWNA (ORCPT ); Fri, 16 Nov 2018 17:13:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:44550 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727727AbeKPWM7 (ORCPT ); Fri, 16 Nov 2018 17:12:59 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EC4D9AF43; Fri, 16 Nov 2018 12:00:53 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 23A001E09B3; Fri, 16 Nov 2018 13:00:53 +0100 (CET) Date: Fri, 16 Nov 2018 13:00:53 +0100 From: Jan Kara To: Mauro Carvalho Chehab Cc: Leon Romanovsky , Dave Jiang , ksummit-discuss@lists.linuxfoundation.org, "linux-nvdimm@lists.01.org" , vishal.l.verma@intel.com, Linux Kernel Mailing List , zwisler@kernel.org Subject: Re: [Ksummit-discuss] [RFC PATCH 3/3] libnvdimm, MAINTAINERS: Subsystem Profile Message-ID: <20181116120053.GD24157@quack2.suse.cz> References: <154225759358.2499188.15268218778137905050.stgit@dwillia2-desk3.amr.corp.intel.com> <154225761038.2499188.1270468803677883744.stgit@dwillia2-desk3.amr.corp.intel.com> <20181115061036.1575223d@silica.lan> <20181115162008.GO3759@mtr-leonro.mtl.com> <20181115110919.46978343@silica.lan> <20181115193520.GA24359@mtr-leonro.mtl.com> <20181116033258.23992cde@silica.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116033258.23992cde@silica.lan> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 16-11-18 03:33:17, Mauro Carvalho Chehab wrote: > Em Thu, 15 Nov 2018 21:35:20 +0200 > Leon Romanovsky escreveu: > > > On Thu, Nov 15, 2018 at 11:09:34AM -0800, Mauro Carvalho Chehab wrote: > > > Em Thu, 15 Nov 2018 18:20:08 +0200 > > > Leon Romanovsky escreveu: > > > > > > > On Thu, Nov 15, 2018 at 06:10:36AM -0800, Mauro Carvalho Chehab wrote: > > > > > Em Thu, 15 Nov 2018 09:03:11 +0100 > > > > > Geert Uytterhoeven escreveu: > > > > > > > > > > > Hi Dan, > > > > > > > > > > > > On Thu, Nov 15, 2018 at 6:06 AM Dan Williams wrote: > > > > > > > Document the basic policies of the libnvdimm subsystem and provide a > > > > > > > first example of a Subsystem Profile for others to duplicate and edit. > > > > > > > > > > > > > > Cc: Ross Zwisler > > > > > > > Cc: Vishal Verma > > > > > > > Cc: Dave Jiang > > > > > > > Signed-off-by: Dan Williams > > > > > > > > > > > > Thanks for your patch! > > > > > > > > > > > > > --- /dev/null > > > > > > > +++ b/Documentation/nvdimm/subsystem-profile.rst > > > > > > > > > > > > > +Trusted Reviewers > > > > > > > +----------------- > > > > > > > +Johannes Thumshirn > > > > > > > +Toshi Kani > > > > > > > +Jeff Moyer > > > > > > > +Robert Elliott > > > > > > > > > > > > Don't you want to add email addresses? > > > > > > Only the first one is listed in MAINTAINERS. > > > > > > > > > > IMO, it makes sense to have their e-mails here, in a way that it could > > > > > easily be parsed by get_maintainers.pl. > > > > > > > > I personally think that list of "trusted reviewers" makes more harm than > > > > good. It creates unneeded negative feelings to those who wanted to be in > > > > this list, but for any reason they don't. Those reviewers will feel > > > > "untrusted". > > > > > > Yeah, perhaps something like "most active reviewers" would sound > > > better. > > > > I would recommend to remove this section at all. > > New maintainers won't come out of blue, but will be come > > from existing community and such individuals for sure will see > > and judge by themselves to whom they trust and to whom not. > > I see your point, but, on the other hand, having a list with the ones > that are actively doing reviews helps newcomers. How exactly? Do you expect people to CC patches to these directly? And if yes, why is not picking patches from the mailing list good enough? Honza -- Jan Kara SUSE Labs, CR