From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262A8C43441 for ; Fri, 16 Nov 2018 15:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDD0E20858 for ; Fri, 16 Nov 2018 15:50:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDD0E20858 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=KARO-electronics.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390025AbeKQCDu convert rfc822-to-8bit (ORCPT ); Fri, 16 Nov 2018 21:03:50 -0500 Received: from smtprelay02.ispgateway.de ([80.67.18.44]:55478 "EHLO smtprelay02.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728434AbeKQCDu (ORCPT ); Fri, 16 Nov 2018 21:03:50 -0500 X-Greylist: delayed 6018 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Nov 2018 21:03:49 EST Received: from [89.1.81.74] (helo=ipc1.ka-ro) by smtprelay02.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gNcjl-0002GC-S7; Fri, 16 Nov 2018 12:56:37 +0100 Date: Fri, 16 Nov 2018 12:56:33 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Thierry Reding , =?UTF-8?B?Vm9rw6HEjQ==?= Michal , Mark Rutland , "devicetree@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Lukasz Majewski , "linux-kernel@vger.kernel.org" , Rob Herring , "kernel@pengutronix.de" , Fabio Estevam , Linus Walleij Subject: Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state Message-ID: <20181116125633.4e110125@ipc1.ka-ro> In-Reply-To: <20181116103929.cxfvuc2te7cadhp2@pengutronix.de> References: <20181107150125.7cpd4v5t7yi2254c@pengutronix.de> <4fbb7307-df01-d7bd-f2e2-e05e6d17807d@ysoft.com> <20181108191855.zuon3ecv4yjfbs7g@pengutronix.de> <283cfef3-16d0-8bd4-e306-6e34d44c3a86@ysoft.com> <20181109165555.vqbiwh4hlcnozdna@pengutronix.de> <20181114113449.GB2620@ulmo> <20181114215120.vddykljqyavm64wj@pengutronix.de> <20181115152545.GA8611@ulmo> <20181115203733.qvonika6yhn2bsnb@pengutronix.de> <20181116095124.GA28631@ulmo> <20181116103929.cxfvuc2te7cadhp2@pengutronix.de> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kZQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Uwe Kleine-König wrote: > Hello Thierry, > > On Fri, Nov 16, 2018 at 10:51:24AM +0100, Thierry Reding wrote: > > On Thu, Nov 15, 2018 at 09:37:33PM +0100, Uwe Kleine-König wrote: > > > On Thu, Nov 15, 2018 at 04:25:45PM +0100, Thierry Reding wrote: [...] > > But why? The backlight doesn't care about the specific pinmuxing of the > > PWM pin. All it cares about is the PWM signal. That's the level of > > abstraction that the PWM consumer expects, anything lower level belongs > > in the PWM driver. > > The backlight driver cares about the PWM pin muxing because if it's > wrongly muxed the backlight doesn't work as intended. > With this argumentation you would also have to define the clocks needed for the PWM in the backlight (or whatever pwm consumer) driver, because if the clocks are not set up correctly the backlight won't work as expected... The PWM driver is driving the pins, so that is where the pinctrls belong. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________