From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3A0C43441 for ; Mon, 19 Nov 2018 08:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A002206BA for ; Mon, 19 Nov 2018 08:48:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A002206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727276AbeKSTL2 (ORCPT ); Mon, 19 Nov 2018 14:11:28 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:45865 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726859AbeKSTL2 (ORCPT ); Mon, 19 Nov 2018 14:11:28 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gOfEG-0007FN-EQ; Mon, 19 Nov 2018 09:48:24 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1gOfEE-000694-L9; Mon, 19 Nov 2018 09:48:22 +0100 Date: Mon, 19 Nov 2018 09:48:22 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Thierry Reding Cc: =?utf-8?B?Vm9rw6HEjQ==?= Michal , Mark Rutland , "devicetree@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Lukasz Majewski , "linux-kernel@vger.kernel.org" , Rob Herring , "kernel@pengutronix.de" , Fabio Estevam , Lothar =?iso-8859-1?Q?Wa=DFmann?= , Linus Walleij Subject: Re: =?iso-8859-1?B?W1JDRqBQQVRDSCx2Miwy?= =?iso-8859-1?B?LzJd?= pwm: imx: Configure output to GPIO in disabled state Message-ID: <20181119084822.qljinfgxpjtumojk@pengutronix.de> References: <283cfef3-16d0-8bd4-e306-6e34d44c3a86@ysoft.com> <20181109165555.vqbiwh4hlcnozdna@pengutronix.de> <20181114113449.GB2620@ulmo> <20181114215120.vddykljqyavm64wj@pengutronix.de> <20181115152545.GA8611@ulmo> <20181115203733.qvonika6yhn2bsnb@pengutronix.de> <20181116095124.GA28631@ulmo> <20181116103929.cxfvuc2te7cadhp2@pengutronix.de> <20181116122445.GA25386@ulmo> <20181118200815.a6hkokt3otfm4yl4@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181118200815.a6hkokt3otfm4yl4@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sun, Nov 18, 2018 at 09:08:15PM +0100, Uwe Kleine-König wrote: > On Fri, Nov 16, 2018 at 01:24:45PM +0100, Thierry Reding wrote: > > On Fri, Nov 16, 2018 at 11:39:29AM +0100, Uwe Kleine-König wrote: > > > Also note that you don't include the poor souls where there is no > > > hardware pullup into the right direction. > > > > The poor souls should speak up and then we can look into finding a good > > solution for them. I'm pretty sure there must be some equivalent that > > can be used for other users. > > I think one of the boards that I'm working with has an enabled backlight > at power on until the bootloader actively drives the related pwm to > the right level (either using the pwm or the gpio function of the pin). > I will double check that but assuming that is right, just disabling the > output won't work here. I just confirmed this. On the board I have in mind the backlight really goes on during powerup. One of the first things the bootloader does is to ensure the backlight goes off again by actively driving the respective pin. I fully agree with you this is unfortunate and the hardware team could have made the situation smoother if there were a pull up. I guess asking them to go back and fix that won't be accepted[1]. So please whatever solution you force through, please consider it should work without a sane pull and also with the imx SoCs before i.MX6 which cannot disable the output driver via pinmux. Best regards Uwe [1] Additionally this is a bought display+backlight+touch combo, so the right place to put the pull would be in this unit, because the board designer rightfully says: I won't put a pull up on my board because for the next batch we're maybe switching to the similar display combo that needs an active high signal for the backlight and I won't create another factor 2 for the board variants for stuff that can be fixed in software. -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |