From: Jonathan Marek <jonathan@marek.ca>
To: bjorn.andersson@linaro.org
Cc: Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2] mfd: qcom_rpm: write fw_version to CTRL_REG
Date: Mon, 19 Nov 2018 14:53:17 -0500 [thread overview]
Message-ID: <20181119195317.22617-1-jonathan@marek.ca> (raw)
In-Reply-To: <20181114224201.16225-1-jonathan@marek.ca>
This is required as part of the initialization sequence on certain SoCs.
If these registers are not initialized, the hardware can be unresponsive.
This fixes the driver on apq8060 (HP TouchPad device).
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
v2: updated the commit message to be more descriptive
I think its important to note that the downstream driver does this for
all versions, so it is safe to add this.
drivers/mfd/qcom_rpm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
index 52fafea06067..8d420c37b2a6 100644
--- a/drivers/mfd/qcom_rpm.c
+++ b/drivers/mfd/qcom_rpm.c
@@ -638,6 +638,10 @@ static int qcom_rpm_probe(struct platform_device *pdev)
return -EFAULT;
}
+ writel(fw_version[0], RPM_CTRL_REG(rpm, 0));
+ writel(fw_version[1], RPM_CTRL_REG(rpm, 1));
+ writel(fw_version[2], RPM_CTRL_REG(rpm, 2));
+
dev_info(&pdev->dev, "RPM firmware %u.%u.%u\n", fw_version[0],
fw_version[1],
fw_version[2]);
--
2.17.1
next prev parent reply other threads:[~2018-11-19 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 22:42 [PATCH] " Jonathan Marek
2018-11-15 8:31 ` Lee Jones
2018-11-19 19:53 ` Jonathan Marek [this message]
2018-11-27 13:03 ` [PATCH v2] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119195317.22617-1-jonathan@marek.ca \
--to=jonathan@marek.ca \
--cc=bjorn.andersson@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®